Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GB-mobile for release 1.33.0 #12480

Merged
merged 4 commits into from
Jul 23, 2020
Merged

Update GB-mobile for release 1.33.0 #12480

merged 4 commits into from
Jul 23, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jul 20, 2020 •
edited
Loading

Integrate version 1.33.0 of Gutenberg for the block editor.

GB PR: wordpress-mobile/gutenberg-mobile#2493

To test:

  • Smoke test the main application flows
  • Check the following new features:
    • [***] Media editing support in Media & Text block.
    • [***] New block: Social Icons
    • [*] Cover block placeholder is updated to allow users to start the block with a background color

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Jul 20, 2020
@SergioEstevao SergioEstevao added this to the 15.4 milestone Jul 20, 2020
@SergioEstevao SergioEstevao requested a review from mchowning July 20, 2020 13:11
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 20, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@SergioEstevao SergioEstevao changed the title Update GB-mobile for release 1.33.0 hash Update GB-mobile for release 1.33.0 Jul 20, 2020
@SergioEstevao SergioEstevao mentioned this pull request Jul 20, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 20, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

mchowning
mchowning approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the latest changes (comment on gb-mobile PR) and everything looks good! :shipit:

@SergioEstevao SergioEstevao merged commit a74badb into develop Jul 23, 2020
@hypest hypest deleted the gutenberg/release_1.33_integration branch July 24, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @mchowning