Guard for nulls in processors and abort if necessary #12114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12104
This PR guards for nulls in the processor Json handling. While it isn't clear why ids would not be present in parsed json from the block header, returning false will leave the content unchanged. Since no changes can be made to the parsed structure without matching the id, aborting should be the safest route.
I believe the reason why the id is missing is that it is not present in the templates, though I have not yet confirmed this.
Steps to test
Expected:
The app should not crash, and upload should complete successfully
Expected:
The url for the added image should be a remote URL (i.e.
https://
notfile://
)PR submission checklist:
RELEASE-NOTES.txt
if necessary.