Fix crash in onSaveInstanceState in Reader #12018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11992
As explained here this issue was introduced with the changes to the BottomNavigation.
However, the root cause of this issue was introduced by Google in AppCompat 1.1.0.
onSaveInstanceState
is invoked even for fragments on back stack which views were never displayed/created. More info here.Downside is that we'll lose scroll position on double rotation, but I don't think it's a big deal. Especially since this will happen only when the user isn't on the Reader tab.
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.This crash was introduced in 14.9-rc-1, so this PR is targeting a frozen branch (cc @oguzkocer).