Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: update to v1.27.0 #11756

Merged
merged 9 commits into from
Apr 30, 2020
Merged

Gutenberg: update to v1.27.0 #11756

merged 9 commits into from
Apr 30, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Apr 27, 2020 •
edited by geriux
Loading

Related PRs

gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2186
WPiOS: wordpress-mobile/WordPress-iOS#14002

To test:

Bug fix

New feature & Improvement

Note: including this to ensure we don't see the block in production yet:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added the Gutenberg Editing and display of Gutenberg blocks. label Apr 27, 2020
@mkevins mkevins added this to the 14.8 milestone Apr 27, 2020
@mkevins mkevins self-assigned this Apr 27, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

This was referenced Apr 27, 2020
Merged
Merged
@mkevins mkevins marked this pull request as ready for review April 27, 2020 10:17
@mkevins mkevins requested a review from geriux April 27, 2020 10:17
@geriux
Copy link
Contributor

geriux commented Apr 27, 2020 •
edited by mkevins
Loading

Writing flow sanity check

  • Undo-redo (steps)
  • Copy-paste (steps)
  • ❌ Splitting blocks (steps) - some known issues (not regressions) need to be added to the test-cases
  • Multiline components (steps)
  • Formatting on rich-text based components (steps)
  • Block insertion (steps)

Splitting and merging - TC001

I encountered a bug where after using swipe text to write a word, deleting does not allow merging the blocks.

Deleting whole swiped word Deleting after a space
split-and-merge-tc001-fail split-and-merge-tc001-works-after-space

This behavior is noted here, so not a regression in this release, but I'm documenting so that we add this as a known issue to the TC001 test-case.

Splitting and merging - TC005

Note: the list test-case should be bumped to TC006 since there already is a TC005.

In the test-case for heading block, pressing backspace transforms the list into a paragraph, then back to heading again:

For a list, the transformation results in the list splitting apart into multiple paragraph blocks, so only the first list item will "retransform" to the last item on the previous list.

Rich text formatting - TC008

✔️ This test case now works on Android, so just noting we can remove the known issue from the test-cases 🎉

@mkevins
Copy link
Contributor Author

mkevins commented Apr 28, 2020 •
edited
Loading

MediaText-1 ✔️

  • Media Text block - Insert image from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing image upload - steps

MediaText-2 ✔️

  • Media Text block - Insert video from device (cancel) - steps
  • Media Text block - Insert image from device (cancel) - steps

MediaText-3 ✔️

  • Media Text block - Insert video from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing video upload - steps

MediaText-4 ✔️

  • Media Text block - Media & Text alignment - steps
  • ❓ Media Text block - Vertical alignment - steps

Small bug with media text block (not a blocker, IMO): after rotating to landscape, the vertical alignment icon is "out of sync" with the state. As soon as you change the value, it syncs again, and remains synced after that.

Screenshot

media-text-vertical-alignment-icon-out-of-sync-after-orientation-change

MultipleUpload-1 ✔️

  • Simultaneous uploads - steps

Shortcode-1 ✔️

  • Shortcode block - Add a youtube link - steps

Cover-2 ✔️

  • Cover - Add Video Background from WordPress Media library - steps
  • Cover - Replace media - steps
  • Cover - Gradient background is rendered properly - steps
  • Cover - Gradient overlay is rendered properly - steps

Columns - 2 ✔️

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • ❔ Columns - Unselected Column placeholder is streched to content in nested structure- steps

Note: these tests may need to be updated to reflect the new position of the floating-toolbar (or mention that the position has changed). In landscape, the floating-toolbar is centered on the screen, not directly above the selected inner block:

Screenshot

columns-nested-landscape-floating-toolbar-centered

Columns - 3 ❌

  • ❌ Columns - Check if in DarkMode all components gets proper colors - steps

This looks like a regression in dark-mode. The appender is white for columns block:

columns-appender-light-in-dark-mode

Unfortunately, this looks like a bug in group and gallery as well. Also, the placeholders in unselected inner blocks are white in darkmode.

appender-and-placeholder-white-in-dark-mode appender-and-placeholder-white-in-dark-mode2

Other issues encountered while testing

Media library images have incorrect orientation

This could be due to a change in the select-from-device and / or upload flow (possibly related to the new picker).

Top two images on the left have incorrect rotation

Done button in paragraph block (landscape mode text editing) leads to loop

When in landscape mode in Android, the edit text enters a landscape mode, which takes up the top half of the screen, with the keyboard occupying the bottom half. After tapping "done", the editor jumps into a new paragraph block, which reopens the keyboard without allowing the user to "escape". I'm not sure if this is considered a bug, or a limitation of the current UX. I haven't yet confirmed if this behavior already exists in a previous release, and I'm merely documenting it here (my gut feeling is that it's not a blocker, since the user can escape via the back button).

Screencast

paragraph-landscape-done-loop

@pinarol
Copy link
Contributor

pinarol commented Apr 29, 2020

Done button in paragraph block (landscape mode text editing) leads to loop

@mkevins This is not a new behavior but I think this is worth revisiting that UX, could you open an issue? Not a blocker for the release imo.

geriux
geriux approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@mkevins mkevins merged commit e358bdd into develop Apr 30, 2020
@mkevins
Copy link
Contributor Author

mkevins commented Apr 30, 2020

Thanks for testing!

@mkevins mkevins deleted the gutenberg/integrate_release_1.27.0 branch April 30, 2020 08:04
@mchowning mchowning mentioned this pull request May 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@mkevins mkevins

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
14.8
Development

Successfully merging this pull request may close these issues.
3 participants
@mkevins @geriux @pinarol