Add Gallery Block #10703
Closed
Add Gallery Block #10703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevins
added
[Status] Not Ready for Review
Gutenberg
This was referenced Oct 25, 2019
|
You can test the changes on this Pull Request by downloading the APK here. |
Generated by 🚫 dangerJS |
3 tasks
mkevins
changed the base branch from
develop
to
fix/multiple-media-selection-handling
This was referenced Nov 27, 2019
Merged
mkevins
changed the base branch from
fix/multiple-media-selection-handling
to
develop
|
This is not necessary anymore since the Gallery block is shipped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a first iteration for a semi-cross-platform Gallery block. This adds the gallery block, which should allow viewing, editing, and creating gallery blocks within the editor. In this 1st iteration, upload options are disabled, and new images can only be added via the WordPress Media Library.
Related PRs
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1498
gutenberg: WordPress/gutenberg#18265
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.