Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _container_ id to post_list_item_compact #10366

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Add _container_ id to post_list_item_compact #10366

merged 1 commit into from
Aug 9, 2019

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Aug 9, 2019

This bug was introduced in #10185

Bug before the patch:

  • on feature/master-remote-previews branch
  • Go to the post list
  • Tap "compact list" button
  • 💥

After the patch:

  • Go to the post list
  • Tap "compact list" button
  • 🏖

@maxme maxme added the Post List label Aug 9, 2019
@maxme maxme requested a review from malinajirka August 9, 2019 08:32
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@maxme maxme mentioned this pull request Aug 9, 2019
Closed
@malinajirka
Copy link
Contributor

LGTM and works as expected;). I'll just wait for lint.

@malinajirka malinajirka merged commit 02514d1 into feature/master-remote-previews Aug 9, 2019
@malinajirka malinajirka deleted the issue/compact-post-list-crash branch August 9, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka malinajirka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxme @malinajirka