Fix/9905 crash inflate exception binary xml file line

[marecar3]

Fixes #9905

The main approach for a potential fix is to increment android material library from 1.0.0 to 1.1.0-rc01.

Reason for that was because the codebase from the library was much improved.

They changed a logic around crashing line from old release and general logic how drawables can be set. https://github.com/material-components/material-components-android/blob/cd59e98f7e2185ddb075ff0fc91f29765d562968/lib/java/com/google/android/material/textfield/TextInputLayout.java#L344
(log -> https://sentry.io/share/issue/9eaadccac3be4c259943d72c46427792/).

Thanks to @mzorz comment 👉 #9905 (comment) I got inspired to make one more step in this fix.

The second approach is to use our own xml which represents show/hide password icon in order to avoid a potential crash if icon can't be found in runtime.

Note: The new version of android material library forced some compile time issues :

⬆️ this was resolved with adding !! and as I am not experienced in Kotlin, if someone has some better approach I am open for suggestions.

To test:

It's very hard to reproduce crash from the logs. However, one should check for potential regressions.

In order to achieve that one should open and check every screen where TextInputLayout or any other component from material library is used. EspeciallyEnter your WordPress password screen should be checked, where password visibility icon (show/hide password) shod work as before (expected).

Update release notes:

• If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

[peril-wordpress-mobile]

	Warnings
⚠️	PR is not assigned to a milestone.

Messages

📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps! WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history! cd WordPress-Android git checkout fix/9905_Crash_InflateException_Binary_XML_file_line git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/WordPress-Android/10279 Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/WordPress-Android/10279 and open a new PR.

Generated by 🚫 dangerJS

[planarvoid]

... this was resolved with adding !! and as I am not experienced in Kotlin, if someone has some better approach I am open for suggestions.

I think you're keeping the previous functionality by this approach (it would've crashed even before if the fragmentManager were null).

If you wanna add a non-null check, you can do something like this:

fragmentManager?.let { nonNullFragmentManager -> 
      dialog.show(nonNullFragmentManager, it)
}

I'm not sure it's worth the extra effort

[mzorz]

I think you're keeping the previous functionality by this approach (it would've crashed even before if the fragmentManager were null).

Exactly - I think Marko's code in that regard looks ok as is, as not having a non-null FragmentManager at any point is probably good to let it crash

[marecar3]

Closing this one in favor of #11172

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.