Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use In-app WebView in Notifications #357

Closed
daniloercoli opened this issue Nov 25, 2013 · 6 comments
Closed

Use In-app WebView in Notifications #357

daniloercoli opened this issue Nov 25, 2013 · 6 comments
Assignees
@daniloercoli
Milestone
2.6

Comments

@daniloercoli
Copy link
Contributor

Instead of opening Chrome, handle navigation inside the app.
WebView should re-use the "wordpress.com" cookie set by the native reader. Or set it, if not available.
@ghost ghost assigned daniloercoli Nov 25, 2013
@daniloercoli
Copy link
Contributor Author

Pushed an update on this in 37849b1.
Found the following issues:

  1. We need to enable JavaScript in the webview, otherwise when opening the blog in the app you will not see some part of it. JS needs to be enabled on 99% of themes.
  2. I used 'ReaderAuthActions.updateCookies' method, already used in the reader, to upgrade the cookie. Otherwise you will not be able to access your wordpress.com blog without re-doing the authetication.
    We should probably move the class ReaderAuthActions outside the reader package (utils?) and re-use it.

@daniloercoli
Copy link
Contributor Author

Fixed in #370

@nbradbury
Copy link
Contributor

Just noticed that NotificationsWebViewActivity calls webView.getSettings().setDisplayZoomControls(false), which isn't supported until API 11. Sorry for not catching that before the merge!

@nbradbury nbradbury reopened this Dec 3, 2013
@daniloercoli
Copy link
Contributor Author

Can we just wrap the call around a check for the version like the following
if (android.os.Build.VERSION.SDK_INT >= 11) ?

@nbradbury
Copy link
Contributor

Yes, that'd be fine. You may want to add @SuppressLint("NewApi") there, too.

daniloercoli added a commit that referenced this issue Dec 3, 2013
@daniloercoli
#357 - Fix an issue where setDisplayZoomControls can be called on dev…
5b26197 
…ices with API < 11 (it isn't supported until API 11).
@daniloercoli
Copy link
Contributor Author

It should be fixed now.

maxme added a commit that referenced this issue Apr 27, 2016
@maxme
Squashed 'libs/editor/' changes from 17887d3..8818dd1
9907504 
8818dd1 Merge pull request #360 from wordpress-mobile/issue/344-remove-blockquotes
a5b021d Check that parent blockquote is the first thing inside the post before applying afterKeyDownEvent fix
ed096e2 Allow individual checks in afterKeyDownEvent to determine if they should go through if the HTML hasn't changed
2206af5 In afterKeyDownEvent, compare before and after HTML and quit if they're the same
23ec38e Refactored afterKeyDownEvent for readability
ae65514 Added generic giveFocusToElement method
cb8cccd Fixed an issue where backspacing doesn't remove a blockquote when it's at the start of a post with more content below it
8f20ff5 Added ZSSField.afterKeyDownEvent, which is called after the results of a keydown event have taken effect
c949332 Merge branch 'develop' of https://github.com/wordpress-mobile/WordPress-Editor-Android into develop
7ce2aa7 Merge branch 'issue/315-paste-fixes' into develop
a00e762 Merge pull request #358 from wordpress-mobile/issue/315-paste-fixes
4a6b534 Merge pull request #357 from wordpress-mobile/issue/350-fix-newlines-api16
edf8b4f Fixed an issue with incorrect paragraph wrapping when starting a post with a blockquote
822ce8f update comment
b8a90b2 Fix newlines when switching to HTML mode on API <= 16
26b7be5 Merge commit 'ac1a4af3be8b6e95d1799ce2f82fca06a73577c0' into develop
1215bdd Make sure text is wrapped in paragraph tags when adding blockquotes
f16e222 Wrap hardware pastes in paragraph tags in empty posts
5e9559f Fix software paste on API<19 by wrapping the paste in paragraph tags after the fact, when a new line is entered
61e5cf3 Wrap software pastes in paragraph tags for API19+ for empty posts
458b6cf Merge pull request #3967 from wordpress-mobile/issue/328editor-track-reflection-failure
9e112be Merge pull request #3961 from wordpress-mobile/issue/3930-crash-when-adding-invalid-image
cf7b400 Merge commit 'be4aac09995c4a35b2354854ef0f3ff5b1ae07e7' into develop
7885bca Use a static listener to handle reflection failures
182e5ef Updates the p/div conversion regex to more strictly match tags
eba46dd Move the addMediaFile logic in an AsyncTask, only WPEditImageSpan construction now lives in a background thread

git-subtree-dir: libs/editor
git-subtree-split: 8818dd1d120140283da46b40b7ad7fc59d772def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniloercoli daniloercoli

Labels
None yet
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
2 participants
@daniloercoli @nbradbury