Address a possible NPE in string comparison for twitter publicize action

wordpress-mobile · Apr 16, 2019 · dc81204 · dc81204
1 parent a227772
commit dc81204
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeActions.java b/WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeActions.java
@@ -162,7 +162,7 @@ public void onErrorResponse(VolleyError volleyError) {
         Map<String, String> params = new HashMap<>();
         params.put("keyring_connection_ID", Long.toString(keyringConnectionId));
         // Sending the external id for Twitter connections result in an error
-        if (!externalUserId.isEmpty() && !serviceId.equals(PublicizeConstants.TWITTER_ID)) {
+        if (!TextUtils.isEmpty(externalUserId) && !PublicizeConstants.TWITTER_ID.equals(serviceId)) {
             params.put("external_user_ID", externalUserId);
         }
         String path = String.format(Locale.ROOT, "/sites/%d/publicize-connections/new", siteId);