Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mark formatter #1339

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Add Mark formatter #1339

merged 3 commits into from
Dec 3, 2021

Conversation

geriux
Copy link

@geriux geriux commented Nov 30, 2021

This PR is a follow-up of #1333 to wrap up adding Mark formatting support.

To test this feature, use the iOS build from this PR that uses this feature.

For test cases, you can check the description of this PR.

@geriux geriux added this to the Next Stable milestone Nov 30, 2021
@geriux geriux changed the title [WIP] - Add Mark formatter Add Mark formatter Nov 30, 2021
@geriux geriux requested a review from antonis November 30, 2021 16:20
@geriux geriux marked this pull request as ready for review November 30, 2021 16:20
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @geriux 👍
I tested this using the steps from the Gutenberg PR and everything works as expected. The code changes also look consistent to me 🎉

@geriux geriux merged commit 95fd245 into develop Dec 3, 2021
@geriux geriux deleted the feature/mark-formatter branch December 3, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants