Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent update selected styles when text changes on Gutenberg mode #949

Merged

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Dec 31, 2021

Related to Gutenberg PR: WordPress/gutenberg#37676

Gutenberg already controls the selected styles, so we need to prevent Aztec from modifying them when the text changes.

Test

This change shouldn't affect the current behavior of the selected styles hence, we should just verify that Aztec works as expected regarding the selected styles when modifying text.

Review

@guarani
@antonis

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

Gutenberg already controls the selected styles so we need to prevent Aztec modifying them when text changes.
@fluiddot fluiddot added the Gutenberg This issue is also valid importing Aztec in Gutenberg label Dec 31, 2021
@fluiddot fluiddot self-assigned this Dec 31, 2021
@fluiddot fluiddot marked this pull request as ready for review January 3, 2022 09:25
@fluiddot fluiddot requested review from antonis and guarani January 3, 2022 09:27
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @fluiddot 👍
I tested the change with a local Android build and everything work as expected. The code change looks consistent to me 🎉

Copy link

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is already approved but I gave it a quick test on Android and it works as expected 👍 Also the code changes on both platforms look very similar.
Thanks for fixing this issue, @fluiddot!

@fluiddot fluiddot merged commit a58cd77 into develop Jan 5, 2022
@fluiddot fluiddot deleted the update/gb-prevent-update-selected-styles-on-change branch January 5, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Gutenberg This issue is also valid importing Aztec in Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants