-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - 지하철 정보 관리 기능] 제이미(임정수) 미션 제출합니다. #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrabcde
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 제이미 ~ 바다입니다 🌊
지하철 미션을 함께 하게 되어 반가워요 ㅎㅎ
마감시간 이후 진행한 커밋이 있어 리뷰규칙에 따라 이번 단계는 바로 merge 하겠습니다 😢
PR 내용에 작성해주신 부족한 테스트 포함해서 2단계까지 진행해주신 뒤에
다시 리뷰요청 보내주세요 ~ 파이팅입니다 💪 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 바다!
미션 장바구니 미션 1단계 PR 요청드립니다.
이번 미션에서는 시간 부족으로 인해 테스트를 대부분 완성하지 못했습니다...!
작성해 주실 1단계 피드백과 함께 테스트도 보충할 수 있도록 하겠습니다 😭
리뷰 잘 부탁드립니다.
감사합니다!