-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - todo list] 손너잘(손민성) 미션 제출합니다 #42
Open
bperhaps
wants to merge
18
commits into
woowacourse:bperhaps
Choose a base branch
from
bperhaps:bperhaps
base: bperhaps
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bperhaps
changed the title
Bperhaps[1단계 - todo list] 손너잘(손민성) 미션 제출합니다
[1단계 - todo list] 손너잘(손민성) 미션 제출합니다
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es6 문법을 이용해서 최대한 모던하게 작성해 봤습니다.
개인적으로 느낀점은, frontend에서 mvc의 의미가 있는가?? 였습니다.
view와 model간의 의존성이 너무 강해서 분리하기가 쉽지 않았고, 결국 완전히 분리는 실패한 것 같습니다.
일단, url의 hash와 사용자의 command(엔터 등..)는 command 패턴을 이용하여 구현하였습니다. 추 후에 다른 기능이 추가 될 수도 있다고 생각했기 때문입니다.
이전에 PR을 보냈었는데, 이벤트 위임 등 성능을 고려하지 않은 구현을 하여 처음부터 다시 짜봤습니다.