Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[항공사 웹사이트의 컴포넌트 접근성 높이기 - 1단계] 병민(윤병인) 미션 제출합니다. #61

Merged
merged 36 commits into from
Oct 11, 2022
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
630230d
chore: 환경설정
airman5573 Oct 6, 2022
9472204
feat: normalize css 적용
airman5573 Oct 6, 2022
f753ff0
chore: sass 사용
airman5573 Oct 6, 2022
e64176d
feat: 기본적인 HTML 골격을 잡는다
airman5573 Oct 6, 2022
9780c9f
chore: MiniCssExtractPlugin 추가
airman5573 Oct 6, 2022
08b7573
feat: 기본 디자인 적용
airman5573 Oct 6, 2022
909e001
feat: HelptipManager 추가
airman5573 Oct 6, 2022
3708c12
feat: SnackbarManager 추가
airman5573 Oct 6, 2022
57b1022
refactor: $를 유틸로 분리
airman5573 Oct 6, 2022
feff9e2
feat: helptip 스타일 추가
airman5573 Oct 6, 2022
4f8a6d0
feat: snackbar style 추가
airman5573 Oct 6, 2022
5fc1dc2
feat: 변경사항 적용
airman5573 Oct 6, 2022
0370a4a
feat: snackbar에 aria-live 적용
airman5573 Oct 6, 2022
e300515
fix: helptip style 수정
airman5573 Oct 6, 2022
7e8703d
fix: 이미 버튼으로 읽히기 때문에 버튼을 삭제한다
airman5573 Oct 6, 2022
8e0f1ac
feat: helptip 닫기 버튼 추가
airman5573 Oct 6, 2022
7ad7992
feat: helptip message에 aria-live 적용
airman5573 Oct 6, 2022
4d262c9
fix: HelptipManager 기본 selector 수정
airman5573 Oct 6, 2022
ffccc13
fix: HelptipManager 맴버 선언
airman5573 Oct 6, 2022
d89d7b4
fix: h1이 안읽히는 문제 해결
airman5573 Oct 6, 2022
aec709f
fix: 레이아웃 오류 수정
airman5573 Oct 6, 2022
16fde3a
feat: 숫자가 바뀔때 스크린 리더가 숫자를 읽도록 설정
airman5573 Oct 6, 2022
a4e6f5d
fix: 키보드로 인원 변경할때 오류 해결
airman5573 Oct 6, 2022
b7b0b67
fix: aria-live off -> polite
airman5573 Oct 7, 2022
679bcdc
fix: polite -> off
airman5573 Oct 7, 2022
1b5baf0
feat: cache buster 적용
airman5573 Oct 7, 2022
5cbc1ec
fix: aria-live 속성을 동적으로 바꾸지 않음
airman5573 Oct 7, 2022
3d5be27
fix: 스크린 리더가 snackbar를 읽도록 한다
airman5573 Oct 10, 2022
aa804f7
fix: snackbar 위치 수정
airman5573 Oct 10, 2022
6c37559
fix: typo
airman5573 Oct 10, 2022
d7a5847
refactor: typo 사용하지 않는 주석 제거
airman5573 Oct 10, 2022
b5f17fc
feat: helptip이 화면에 나왔을떄 스크린 리더가 바로 읽도록 한다
airman5573 Oct 10, 2022
55d1a96
test
airman5573 Oct 10, 2022
e7ed7d3
feat: aria-live를 통일한다
airman5573 Oct 10, 2022
0ec4999
fix: helptip-content에 aria-hidden을 적용한다
airman5573 Oct 10, 2022
a91ad96
refactor: 명시적인 class를 사용한다
airman5573 Oct 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: polite -> off
airman5573 committed Oct 7, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 679bcdcf2f074480b93a352bb2cf122ef73227fb
2 changes: 1 addition & 1 deletion src/SnackbarManager.js
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ class SnackbarManager {

hide() {
this.#check();
this.#element.setAttribute('aria-live', 'polite');
this.#element.setAttribute('aria-live', 'off');
this.#element.classList.remove('show');
}
}
2 changes: 1 addition & 1 deletion src/index.html
Original file line number Diff line number Diff line change
@@ -36,6 +36,6 @@ <h2>승객 선택</h2>
</div>
</div>
</div>
<div id="snackbar" role="status" aria-live="polite"></div>
<div id="snackbar" role="status"></div>
</body>
</html>