Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] 방 참여 가능 조회 API 수정 #247

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[HOTFIX] 방 참여 가능 조회 API 수정 #247

merged 1 commit into from
Aug 23, 2024

Conversation

jhon3242
Copy link
Member

Issue Number

close #246

As-Is

방 참여 가능 조회 API가 락을 통해 조회하는 메서드를 사용중이였다.

To-Be

  • 방 참여 가능 조회 API가 락을 사용하지 않고 조회하도록 수정
  • 유효하지 않는 방 ID로 요청이 예외가 아니라 false 를 리턴하도록 변경

Check List

  • 테스트가 전부 통과되었나요?
  • 모든 commit이 push 되었나요?
  • merge할 branch를 확인했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

Test Screenshot

(Optional) Additional Description

@jhon3242 jhon3242 added 🚨 hotfix 핫픽스 🍃 BE back end 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) labels Aug 23, 2024
@jhon3242 jhon3242 added this to the BE Sprint4 milestone Aug 23, 2024
@jhon3242 jhon3242 self-assigned this Aug 23, 2024
@jhon3242 jhon3242 merged commit 8a85230 into main Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 BE back end 🔥 Emergency 긴급 처리(2명 리뷰 머지 PR) 🚨 hotfix 핫픽스
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant