-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 다이얼로그 중첩 현상 수정 #511
The head ref may contain hidden characters: "fix/#510_\uB2E4\uC774\uC5BC\uB85C\uADF8_\uC911\uCCA9_\uD604\uC0C1_\uC218\uC815"
fix: 다이얼로그 중첩 현상 수정 #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생했습니다! 뽀또!!
고민해볼만한 코멘트 하나 남겼어요. 확인해주시고 다시 요청주시면 좋을 것 같습니다!
override fun onPause() { | ||
super.onPause() | ||
supportFragmentManager.fragments.forEach { fragment -> | ||
if (fragment.tag == GIVE_UP || fragment.tag == HINT || fragment.tag == LETTER) { | ||
supportFragmentManager.beginTransaction().remove(fragment).commit() | ||
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3]
override fun onPause() {
super.onPause()
val tags = listOf(GIVE_UP, HINT, LETTER)
supportFragmentManager.fragments.forEach { fragment ->
if (tags.contains(fragment.tag)) {
supportFragmentManager.beginTransaction().remove(fragment).commit()
}
}
}
이렇게 구현해도 좋겠네요. tags는 동반 객체로 옮기고요.
고민해보시라고 남겨봅니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 훨씬 깔끔한데요?! 바로 반영하겠습니다!👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빠르게 반영해주어서 감사합니다!
머지하도록 할게요!
📌 관련 이슈
🛠️ 작업 내용
🎯 리뷰 포인트
⏳ 작업 시간
추정 시간: 1h
실제 시간: 1h