Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunji1203
requested changes
Oct 12, 2023
Comment on lines
21
to
22
| @Query("latitude") latitude: String, | ||
| @Query("longitude") longitude: String, |
There was a problem hiding this comment.
Suggested change
| @Query("latitude") latitude: String, | |
| @Query("longitude") longitude: String, | |
| @Query("latitude") latitude: Double, | |
| @Query("longitude") longitude: Double, |
노션을 보니 해당 쿼리 타입이 Double인 것 같아요!
아니면 String으로 해도 되는건가요?! 몰라서 물어봅니다!
| TODO("Not yet implemented") | ||
| } | ||
|
|
||
| override suspend fun fetchNearbyLetters(latitude: String, longitude: Coordinate): List<ClosedLetter> { |
There was a problem hiding this comment.
Suggested change
| override suspend fun fetchNearbyLetters(latitude: String, longitude: Coordinate): List<ClosedLetter> { | |
| // 1번 방식 | |
| override suspend fun fetchNearbyLetters(latitude: Double, longitude: Double): List<ClosedLetter> { | |
| // 2번 방식 | |
| override suspend fun fetchNearbyLetters(coordinate: Coordinate): List<ClosedLetter> { |
이렇게 바뀌어야 할 것 같아요!
| longitude: Coordinate, | ||
| ): OpenLetter | ||
|
|
||
| suspend fun fetchNearbyLetters(latitude: String, longitude: Coordinate): List<ClosedLetter> |
|
|
||
| import com.now.domain.model.type.LogType | ||
|
|
||
| data class LetterLog( |
There was a problem hiding this comment.
해당 도메인은 더 이상 사용 되고 있지 않는 것 같아요!
hyunji1203
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🛠️ 작업 내용
🎯 리뷰 포인트
⏳ 작업 시간
추정 시간: 1h
실제 시간: 2h
어렵네요.. 도메인, DTO 짜는거..