-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 회원 탈퇴 기능 구현 #335
Merged
+116
−2
Merged
feat: 회원 탈퇴 기능 구현 #335
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9a14819
feat: 서버와 회원 탈퇴 통신을 해주는 service 추가
hyunji1203 fcbba63
feat: 카카오 sdk의 unlink 메서드 추가
hyunji1203 bb4f3ac
feat: 회원 탈퇴 기능 추기
hyunji1203 c2e3b17
feat: 회원탈퇴 버튼 클릭 시 회원 탈퇴가 되도록 하는 기능 구현
hyunji1203 afa4ed5
feat: Service의 API 주소 수정
hyunji1203 42cc780
refactor: Service의 반환 값 수정
hyunji1203 7514d45
feat: 로그 수정
hyunji1203 b59de6a
refactor: ktlint 수정
hyunji1203 5c0017f
refactor: 메서드 반환 값이 non-nullable 하도록 수정
hyunji1203 e38a94c
refactor: 변수명 변경
hyunji1203 8d1cb31
refactor: 에러 코드 상수화
hyunji1203 ec95fdf
refactor: 회원 탈퇴 repository 메서드 내 runCatching 삭제
hyunji1203 29df463
feat: 회원 탈퇴 후 로그인 창으로 이동 시 백 스택에 쌓인 뷰를 리셋해주는 기능 구현
hyunji1203 7d5d5e2
feat: 회원 탈퇴 다이얼로그 생성
hyunji1203 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
android/app/src/main/java/com/now/naaga/presentation/setting/SettingViewModel.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2]
현재 액티비티를 종료하고 로그인 액티비티로 넘어가게 해두었는데, 아마 디바이스의 뒤로가기를 클릭하면 MyPage가 나올 것 같아요.
만약 그렇다면 수정이 필요해보입니다!
실제로 확인해보지는 못해서 이따가 한번 더 확인해보도록 하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1]
확인해보았는데 회원탈퇴가 성공적으로 진행된 뒤에 로그인 액티비티로 넘어가지만 디바이스의 뒤로가기를 크릭하면 MyPage가 나옵니다. 이 부분은 수정이 필요할 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 크롱 리뷰를 하면서 백스택에 쌓인 액티비티를 리셋해주고 원하는 액티비티를 띄우게 해주는 로직을 보고, 해당 로직 회원 탈퇴에도 적용시켰습니다!
크롱 덕에 빨리 키워드를 찾아 공부하고 수정할 수 있었네요ㅎㅎ 잘 배워갑니다!!!!