-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] Refactor/#628 시맨틱 태그, 웹 표준, 웹 접근성 검토 #629
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8a33ab8
refactor: home 및 layout 시맨틱 태그 수정
semnil5202 887fa6e
refactor: topicCard 및 Container 시맨틱 태그 수정
semnil5202 d8c190d
chore: switch default off eslint 설정
semnil5202 99536c8
refactor: 불필요한 profile img 제거
semnil5202 62e696b
refactor: banner section 시맨틱 태그 적용
semnil5202 87d26f7
refactor: 즐겨찾기, 내토픽리스트 시맨틱 태그 적용
semnil5202 dd2d2d7
refactor: topicInfo 시맨틱 태그 수정
semnil5202 5a7b491
refactor: Map 시맨틱 태그 수정
semnil5202 22781fb
refactor: topicCard, Container li 및 article 시맨틱 태그 수정
semnil5202 605a36b
refactor: 페이지 컴포넌트 시맨틱 태그 일괄 수정
semnil5202 c230aec
refactor: Search 페이지 layout width 지정 및 nav highlight 수정
semnil5202 7ac99a7
refactor: PinDetail h2, h3 시맨틱 태그 적용
semnil5202 eb2d6c3
refactor: Logo aria-label 수정
semnil5202 2a8bdbd
refactor: Banner aria-label 수정
semnil5202 e20f8b0
refactor: TopicCard 및 Image 공통 컴포넌트 등 aria-label 수정
semnil5202 95a4cbe
refactor: topicInfo 접근성 로직 리팩토링
semnil5202 1873fe8
test: cypress 테스트 data-cy 태그 의존성으로 변경
semnil5202 a00a904
refactor: PinPreview 및 뽑아오기 접근성 로직 수정
semnil5202 853781c
refactor: 개발서버 부재에 따른 api 위치 변경
semnil5202 7f725a8
refactor: URL 주소 공유하기 버튼 접근성 로직 수정
semnil5202 feffb7c
refactor: pinDetail 및 상세보기 버튼 접근성 로직 추가
semnil5202 100f4f9
refactor: 댓글 및 답글 접근성 로직 추가
semnil5202 bc9be16
refactor: 불필요한 console.log 제거
semnil5202 eec2293
refactor: 지도 추가하기 접근성 로직 수정
semnil5202 71a560b
refactor: 핀 생성 접근성 로직 수정
semnil5202 d4147d2
refactor: 각 영역 전체보기 페이지 접근성 로직 수정
semnil5202 61221a5
refactor: 즐겨찾기 및 나의 지도 접근성 로직 수정
semnil5202 42a9b76
refactor: 내 정보 컨테이너 접근성 로직 수정
semnil5202 a2bf4be
refactor: 지도, 핀, 닉네임 수정하기 접근성 로직 추가
semnil5202 f464444
design: 크로스 브라우징 UI 일관성을 위해 체크 박스 스타일 조정
semnil5202 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스크린리더에 이로운 role까지 주다니 굿 👍