Feature/#559 행사에 여러 개 이미지 등록 기능 구현 #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java-saeng
added
Backend
amaran-th
approved these changes
Sep 20, 2023
hong-sile
approved these changes
Sep 20, 2023
| POST | ||
|
|
||
| [source] | ||
| ---- |
| @@ -183,54 +201,42 @@ void updateEventTest() throws Exception { | |||
| event.getInformationUrl(), event.getEventPeriod().getStartDate(), | |||
| event.getEventPeriod().getEndDate(), | |||
| event.getEventPeriod().getApplyStartDate(), event.getEventPeriod().getApplyEndDate(), tags, | |||
| event.getImageUrl(), event.getType(), EventMode.OFFLINE, PaymentType.PAID); | |||
| event.getImageUrl(), event.getType(), EventMode.OFFLINE, PaymentType.PAID, null); | |||
There was a problem hiding this comment.
사소한 부분입니다.
여기서 request에서 MultipartFile 부분을 null을 주시고, 실제 response에서는 반환을 하도록 하셨더라고요.
코드 상으론 전혀 문제가 없지만 나중에 문서를 읽어보는 입장에서는 조금 헷갈릴 수도 있을 것 같아요.
There was a problem hiding this comment.
감사합니다 response 도 null 로 바꿔버렸습니다
| .param("startDateTime", | ||
| request.getStartDateTime().format(DateTimeFormatter.ofPattern("yyyy:MM:dd:HH:mm:ss"))) | ||
| .param("endDateTime", | ||
| request.getEndDateTime().format(DateTimeFormatter.ofPattern("yyyy:MM:dd:HH:mm:ss"))) |
| //when & then | ||
| mockMvc.perform(post("/events") | ||
| .param("name", "인프콘 2023") | ||
| .param("location", "코엑스") |
hyeonjerry
approved these changes
Sep 20, 2023
|
|
||
| @RequiredArgsConstructor | ||
| @Getter | ||
| @Setter |
There was a problem hiding this comment.
혹시 이 setter가 어디서 필요한건가요?
There was a problem hiding this comment.
쿼리 스트링으로 객체 받으려면 setter를 써야하는 것으로 알고 있어서 작성해주었습니다!
제가 잘못 알고 있다면 말씀해주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
예상 소요 시간 및 실제 소요 시간
9/21 예상
9/20 완료