Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaran-th
requested changes
Sep 20, 2023
| .andDo(print()) | ||
| .andDo(document("post-feed", requestFields, responseFields)); | ||
| .andExpect(status().isCreated()); | ||
| //.andDo(document("post-feed", requestFields, responseFields)); |
There was a problem hiding this comment.
혹시 문서화 로직을 주석처리 해두신 이유가 있으신가요?
| @RequestPart final FeedPostRequest feedPostRequest, | ||
| @RequestPart(required = false) final List<MultipartFile> images | ||
| ) { | ||
| System.out.println("d"); |
There was a problem hiding this comment.
불필요한 출력문은 지워주시면 좋을 것 같습니다!
…023-emmsale into Feature/#562-피드_이미지_업로드
…023-emmsale into Feature/#562-피드_이미지_업로드
java-saeng
approved these changes
Sep 21, 2023
| @@ -38,6 +47,8 @@ class FeedCommandServiceTest extends ServiceIntegrationTestHelper { | |||
| private MemberRepository memberRepository; | |||
| @Autowired | |||
| private EventRepository eventRepository; | |||
| @MockBean | |||
There was a problem hiding this comment.
이곳에 @MockBean을 추가하면 새로운 컨테이너가 띄워져서 ServiceIntegrationTestHelper에 넣는거 어떠신가요
hong-sile
approved these changes
Sep 21, 2023
amaran-th
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
clse #562
📝작업 내용
피드 이미지 업로드 기능 구현
예상 소요 시간 및 실제 소요 시간
1일/1일