[BE] issue359: 기존 githubId 사용하던 곳 모두 memberId 로 변경 #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Analysis Details1 Issue
Coverage and Duplications
Project ID: woowacourse-teams_2022-moamoa_AYKvd_z4VbW_bWBvgn13 |
sc0116
reviewed
Sep 19, 2022
| @@ -18,7 +18,7 @@ public class ReviewDao { | |||
|
|
|||
| public List<ReviewData> findAllByStudyId(final Long studyId) { | |||
| String sql = "SELECT review.id, review.content, review.created_date, review.last_modified_date, " | |||
| + "member.github_id, member.username, member.image_url, member.profile_url " | |||
| + "member.id as member_id, member.username, member.image_url, member.profile_url " | |||
There was a problem hiding this comment.
ㅎㅎ 이 부분과 LinkDao 부분을 제가 저번 PR에서 확인하지 못해 기능 구현하다가 오류가 많이나서 당황했네욤... 더 꼼꼼한 리뷰 남길게요 ㅎㅎ
| @@ -75,7 +73,7 @@ void getStudyDetails() { | |||
| .body("enrollmentEndDate", is(지금.plusDays(4).toString())) | |||
| .body("startDate", is(지금.toString())) | |||
| .body("endDate", is(지금.plusDays(10).toString())) | |||
| .body("owner.id", is((int)디우_깃허브_ID)) | |||
| .body("owner.id", not(empty())) | |||
There was a problem hiding this comment.
요거도 좋지만 정보 가져와서 실제 디우(방장)의 아이디 넣어줘서 확인하는건 어떠세요? 저는 그렇게 고치고 있어요!
There was a problem hiding this comment.
오..!! 저는 아래와 같은 방식으로 id를 가져오려고 했는데 잘 안되어서 empty() 로 해주었는데요..
혹시 짱구는 어떻게 아이디를 가져와서 비교해주셨나요!!
final MemberResponse 디우_정보 = 디우가().로그인하고().정보를_가져온다();
verus-j
approved these changes
Sep 28, 2022
jaejae-yoo
approved these changes
Sep 29, 2022
sc0116
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
memberId 를 응답으로 내려주도록 수정
세부사항
ArgumentResolver는 제거하였지만, 여전히 몇몇 API 에서 githubId 를 응답으로 내려주고 있습니다.해당 부분을 모두 통일성 있게 memberId로 수정을 진행해야 합니다.
close #359