Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] issue134: 내 스터디 페이지 생성 #166

Merged
merged 7 commits into from
Jul 30, 2022

Conversation

airman5573
Copy link
Collaborator

요약

내 스터디 페이지를 생성하고, 헤더에 내 스터디 페이지로 이동하는 버튼을 추가했습니다.

close #134

@airman5573 airman5573 added 🚀 feature New feature or request 😁 frontend New frontend feature labels Jul 29, 2022
@airman5573 airman5573 requested a review from nan-noo July 29, 2022 09:24
Comment on lines +3 to +4
import reviewJSON from './reviews.json';
import studiesJSON from './studies.json';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

절대경로 사용해야겠네용

Comment on lines +26 to +29
{myStudies.map(myStudy => (
<li key={myStudy.id}>
<MyStudyCard
title={myStudy.title}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

myStudies의 length가 0일때는 '스터디가 없습니다'를 보여주도록 수정해야겠네요!

@nan-noo nan-noo merged commit 4e7fd77 into develop Jul 30, 2022
@nan-noo nan-noo deleted the feat/134-my-study-page branch July 30, 2022 04:00
@nan-noo nan-noo linked an issue Jul 30, 2022 that may be closed by this pull request
import { tokenHandlers } from './tokenHandlers';
import detailStudyHandlers from '@mocks/detailStudyHandlers';
import { myHandlers } from '@mocks/myHandlers';
import { reviewHandlers } from '@mocks/reviewHandler';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 지워야겠네요!

@@ -89,4 +91,6 @@ export const handlers = [
...detailStudyHandlers,
...tagHandlers,
...tokenHandlers,
...myHandlers,
...reviewHandlers,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘도!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature New feature or request 😁 frontend New frontend feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 내 스터디 목록 페이지 구현
2 participants