Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] issue113: 스터디 필터를 통한 조회 리팩토링 #121

Merged
merged 2 commits into from
Jul 25, 2022
Merged

[BE] issue113: 스터디 필터를 통한 조회 리팩토링 #121

merged 2 commits into from
Jul 25, 2022

Conversation

tco0427
Copy link
Collaborator

@tco0427 tco0427 commented Jul 25, 2022

요약

스터디 필터를 통한 조회 리팩토링

세부사항

리팩토링 사유

  • CQRS 를 지키기 위해서
  • 중간에 StudyTag 라고 하는 객체지향적이지 않은 클래스의 제거
  • 패키지 구조 변경 시에 Querydsl 을 위해서 빌드를 새롭게 해주어야하는 번거로움

close #113

@tco0427 tco0427 added 🖥 backend New backend feature 🛠 refactoring Refactor code labels Jul 25, 2022
@tco0427 tco0427 requested review from verus-j, sc0116 and jaejae-yoo July 25, 2022 11:27
@tco0427 tco0427 self-assigned this Jul 25, 2022
@tco0427 tco0427 merged commit aeafcc8 into develop Jul 25, 2022
sc0116
sc0116 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@sc0116 sc0116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

짱디우 확인했습니다~

backend/src/main/java/com/woowacourse/moamoa/study/domain/Study.java

private void validatePeriod(final Period period) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메소드 분리 굿

@verus-j verus-j deleted the refactor/113-search-by-tags branch July 26, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaejae-yoo jaejae-yoo jaejae-yoo approved these changes

@sc0116 sc0116 sc0116 approved these changes

@verus-j verus-j Awaiting requested review from verus-j

Assignees

@tco0427 tco0427

Labels
🖥 backend New backend feature 🛠 refactoring Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tco0427 @sc0116 @jaejae-yoo