-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] issue75: 이미지 에러 및 스터디 상세 페이지 수정 #104
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7c102ac
feat: src 없을 때 이미지 처리
nan-noo d3aaf63
feat: 에러페이지 구현
nan-noo 8288f13
Merge branch 'develop' of https://github.com/nan-noo/2022-moamoa into…
nan-noo a914ba9
fix: 모집중, 모집완료 수정
nan-noo efd9614
refactor: 스터디 상세 페이지 수정
nan-noo 5590847
style: 스터디 리뷰 섹션 스타일 수정
nan-noo eaf481e
style: 메인 페이지 카드 너비 균일화
nan-noo ebcca05
refactor: 컴포넌트 이름 변경
nan-noo 5d617d9
refactor: 사용하지 않는 className 속성 삭제
nan-noo bdbea99
feat: 선택요소 에러 처리
nan-noo f327196
refactor: 변경된 api 명세에 맞춰 타입 수정
nan-noo 19ec5ad
Merge branch 'develop' of https://github.com/nan-noo/2022-moamoa into…
nan-noo 9a8a364
fix: mock data 수정
nan-noo 3a949e0
fix: api 명세에 맞춰 type, props 수정
nan-noo fc1dbb6
refactor: 0px 제거
nan-noo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
API_URL="http://52.79.214.158:8080" | ||
API_URL="" | ||
CLIENT_ID="cb83d95cd5644436b090" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
API_URL="http://52.79.214.158:8080" | ||
API_URL="" | ||
CLIENT_ID="cb83d95cd5644436b090" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import notFoundImage from '@assets/images/no-image-found.png'; | ||
|
||
interface ImageProps { | ||
className?: string; | ||
src: string; | ||
alt: string; | ||
} | ||
|
||
const Image: React.FC<ImageProps> = ({ className, src, alt }) => { | ||
const handleImageError = ({ currentTarget }: React.SyntheticEvent<HTMLImageElement>) => { | ||
currentTarget.src = notFoundImage; | ||
}; | ||
|
||
return <img className={className} src={src} alt={alt} onError={handleImageError} />; | ||
}; | ||
|
||
export default Image; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,11 @@ | ||
import Chip from '@components/chip/Chip'; | ||
|
||
type StudyChipProps = { | ||
className?: string; | ||
isOpen: boolean; | ||
}; | ||
|
||
const StudyChip = ({ className, isOpen }: StudyChipProps) => { | ||
return ( | ||
<Chip className={className} disabled={!isOpen}> | ||
{isOpen ? '모집중' : '모집완료'} | ||
</Chip> | ||
); | ||
const StudyChip = ({ isOpen }: StudyChipProps) => { | ||
return <Chip disabled={!isOpen}>{isOpen ? '모집중' : '모집완료'}</Chip>; | ||
}; | ||
|
||
export default StudyChip; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상수로 분리하면 더 좋겠네요