test: fuzz mdx parser #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may want to wait on #26, currently |
wooorm
reviewed
Oct 29, 2022
fuzz/fuzz_targets/markdown.rs
Outdated
| let _ = markdown::to_mdast(s, &markdown::ParseOptions::default()); | ||
| let _ = markdown::to_mdast(s, &markdown::ParseOptions::gfm()); | ||
| let _ = markdown::to_mdast(s, &markdown::ParseOptions::mdx()).ok(); |
There was a problem hiding this comment.
What does the .ok() add? I believe it’ll work fine without it: that it’s a result and doesn’t panic?
There was a problem hiding this comment.
My impression is/was that some errors are to be expected with MDX?
My goal is to capture/ignore known errors, and only look for unexpected panic!.
That understand could be incorrect though.
Is the goal with the mdx parser to never throw?
in the meantime removed .ok
There was a problem hiding this comment.
also related #26 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
.ok()to theResultto capture and ignore recoverable errors.