Two small bugfixes for parser #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix parser breaking MD files without header section
markkane
commented
Oct 12, 2022
| @@ -86,7 +86,7 @@ function splice(cont, idx, rem, str) { | |||
| } | |||
|
|
|||
| function getHeaders(content) { | |||
| const index = content.indexOf("---", 1) + "---".length; | |||
| const index = content.indexOf("---") < 0 ? 0 : content.indexOf("---", 1) + "---".length; | |||
There was a problem hiding this comment.
If a MD file has no header section this line could cause breaking changes to the file. If the file has no header the slice index should be 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix paths issue on windows systems,
fix parser breaking MD files without header section