-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DOCKER_HOST
env to search for docker before searching for a hardcode docker socket
#763
Use DOCKER_HOST
env to search for docker before searching for a hardcode docker socket
#763
Conversation
I haven't test the PR yet, might not have time before the weekend, so that's more a proposal. |
The DOCKER_HOST could be a URL: https://docs.docker.com/engine/security/protect-access/
I think as long as the environment exists, we do not to check the existence again. |
076d656
to
71aa99b
Compare
Ok so more like this ? |
Now it looks good 😊 |
DOCKER_HOST
env to check for docker befor looking for hardcode docker socket
DOCKER_HOST
env to check for docker befor looking for hardcode docker socketDOCKER_HOST
env to search for Docker before searching for a hardcode Docker socket
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=======================================
Coverage 52.23% 52.23%
=======================================
Files 86 86
Lines 5940 5940
=======================================
Hits 3103 3103
Misses 2665 2665
Partials 172 172
Continue to review full report at Codecov.
|
DOCKER_HOST
env to search for Docker before searching for a hardcode Docker socketDOCKER_HOST
env to search for docker before searching for a hardcode docker socket
Document DOCKER_HOST environment variable as described at woodpecker-ci#763
Document DOCKER_HOST environment variable as described at #763
Fix #757