-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two row layout for title and context of pipeline list #4625
Conversation
Can you add a screenshot? |
Added one to the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im really missing the #<pipeline number>
information. Can we add it back?
Would it be better to have it in the second line? This line already holds other static metadata while the first one holds the title information. |
Fine for me as well even if I like it more in the title. If we add it to the second line I would add as the first element and we need to add an |
Can do that, but then I need you CSS help. The problem is that I'd like to have it in a grid to have icons under icons and text under text. That works for the commit hash because it's always 8 chars, so the width can be fixed, but the pipeline number can be endless. Is there a way to "sync" the width of the ID field over all pipelines in the list? |
Not sure if I can follow. But IMO this is getting way too complicated now. Either keep it in the title as it was before or leave it out and improve it in a dedicated PR. |
I want to have a consistency in all the second lines. I.e. all pipeline numbers, all commit hashs, all contexts (branch, pr) in one line. But I also think first line is fine |
Ok got it, thanks. I can look into this in another PR if you like. |
I have looked into this and I am sure that this will not work, at least not with pure CSS. |
Temporary OK, if you commit to look into this in more detail. The question is just what happens if this is "not so easy" or gets stuck - then we have a complicated discussion. Maybe the motivation would be higher for a follow-up PR if the workaround wouldn't be included? 🙈️ Your choice, I'm either way. |
Just dont like that we loose a functionality here. To be honest I dont know how to solve the issue with the second line. This is not only an issue with the pipeline number. With the current approach we will get this problem with every other information that can have a dynamic length. |
The other alternative it to accept that we will get a similar look like this with the second line: @qwerty287 could we live with that? I know its not optimal but I dont even see a way with javascript without adding a lot of complexity. |
I think on github it looks better, maybe because you can really see the different widths. In the pipeline list these are very small differences, so not directly visible, but you still see that something is wrong and unaligned there. |
Ok then I have no idea how to proceed. |
Tearing down https://woodpecker-ci-woodpecker-pr-4625.surge.sh |
supersedes #3976
Before:
After: