Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker in docker example to advanced usage in docs #4620

Merged
merged 13 commits into from
Dec 27, 2024

Conversation

plafue
Copy link
Contributor

@plafue plafue commented Dec 26, 2024

No description provided.

Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have been thinking about adding this in the past as well, so surely good to have. And the place matches as well.

I would say that there should be an additional note at the top which states something like "use the buildx plugins by default, this is only a fallback for advanced/custom use of docker build".

In regards to that (and this might answer the second question): what has motivated you to go this route instead of using the buildx plugin? (this would be a good use case example to add as well).

docs/docs/20-usage/90-advanced-usage.md Outdated Show resolved Hide resolved
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Dec 26, 2024

Deployment of preview was torn down

docs/docs/20-usage/90-advanced-usage.md Outdated Show resolved Hide resolved
docs/docs/20-usage/90-advanced-usage.md Outdated Show resolved Hide resolved
docs/docs/20-usage/90-advanced-usage.md Outdated Show resolved Hide resolved
@plafue
Copy link
Contributor Author

plafue commented Dec 26, 2024

@pat-s i rewrote the section quite a bit, guiding the reader through the changes and a bit of reasoning behind them. Became a bit wordy. i hope it's ok. Otherwise, feel free to make changes at your own discretion.

@pat-s
Copy link
Contributor

pat-s commented Dec 26, 2024

Thanks, I'll check again later and apply suggestions as needed then 👍

@pat-s pat-s enabled auto-merge (squash) December 27, 2024 14:46
@pat-s pat-s merged commit 7135abb into woodpecker-ci:main Dec 27, 2024
7 checks passed
@plafue
Copy link
Contributor Author

plafue commented Dec 27, 2024

Thanks for the support, @pat-s !

@woodpecker-bot woodpecker-bot mentioned this pull request Dec 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants