-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker in docker example to advanced usage in docs #4620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have been thinking about adding this in the past as well, so surely good to have. And the place matches as well.
I would say that there should be an additional note at the top which states something like "use the buildx plugins by default, this is only a fallback for advanced/custom use of docker build".
In regards to that (and this might answer the second question): what has motivated you to go this route instead of using the buildx plugin? (this would be a good use case example to add as well).
Deployment of preview was torn down |
Co-authored-by: Patrick Schratz <[email protected]>
@pat-s i rewrote the section quite a bit, guiding the reader through the changes and a bit of reasoning behind them. Became a bit wordy. i hope it's ok. Otherwise, feel free to make changes at your own discretion. |
Thanks, I'll check again later and apply suggestions as needed then 👍 |
Thanks for the support, @pat-s ! |
No description provided.