-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user as docker backend_option #4526
Conversation
d154eac
to
5212cb3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4526 +/- ##
==========================================
+ Coverage 28.23% 28.26% +0.03%
==========================================
Files 398 399 +1
Lines 28167 28179 +12
==========================================
+ Hits 7953 7966 +13
+ Misses 19508 19507 -1
Partials 706 706 ☔ View full report in Codecov by Sentry. |
Deployment of preview was torn down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, untested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I just saw that https://github.com/mitchellh/mapstructure is archived 😢 |
I can look into a replacement |
As Woodpecker is now able to use non-root images #4151 it would be helpful to be able to set the run user per step. This PR exposes
user
as backend option for the docker backend.