Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user as docker backend_option #4526

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Add user as docker backend_option #4526

merged 2 commits into from
Dec 8, 2024

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Dec 7, 2024

As Woodpecker is now able to use non-root images #4151 it would be helpful to be able to set the run user per step. This PR exposes user as backend option for the docker backend.

@xoxys xoxys requested a review from a team December 7, 2024 21:58
@xoxys xoxys added server feature add new functionality labels Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.26%. Comparing base (6e18a44) to head (2ffcd2f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/backend/docker/docker.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4526      +/-   ##
==========================================
+ Coverage   28.23%   28.26%   +0.03%     
==========================================
  Files         398      399       +1     
  Lines       28167    28179      +12     
==========================================
+ Hits         7953     7966      +13     
+ Misses      19508    19507       -1     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Dec 7, 2024

Deployment of preview was torn down

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, untested

Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pat-s pat-s merged commit 786a8fb into main Dec 8, 2024
9 checks passed
@pat-s pat-s deleted the docker-run-user branch December 8, 2024 11:02
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 8, 2024
1 task
@qwerty287
Copy link
Contributor

I just saw that https://github.com/mitchellh/mapstructure is archived 😢

@xoxys
Copy link
Member Author

xoxys commented Dec 8, 2024

I can look into a replacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants