Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set new default approval mode based on repo visibility #4456

Merged
merged 26 commits into from
Dec 5, 2024
Merged

Set new default approval mode based on repo visibility #4456

merged 26 commits into from
Dec 5, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 25, 2024 •
edited
Loading

if not already altered by user

build upon #4429 merged and released with v2.8.0

@6543 6543 added enhancement improve existing features breaking will break existing installations if no manual action happens security labels Nov 25, 2024
6543
6543 commented Nov 25, 2024
View reviewed changes
server/api/repo.go Outdated Show resolved Hide resolved
@6543 6543 mentioned this pull request Nov 25, 2024
Merged
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Nov 25, 2024 •
edited
Loading

Deployment of preview was torn down

@6543 6543 requested a review from anbraten November 25, 2024 20:37
@6543
Copy link
Member Author

6543 commented Nov 26, 2024

@anbraten your backport was merged ... so this should be merged soon too ...

@6543 6543 added this to the 3.0.0 milestone Nov 28, 2024
@6543 6543 requested a review from a team November 28, 2024 19:17
pat-s
pat-s reviewed Dec 1, 2024
View reviewed changes
cli/repo/repo_update.go Outdated Show resolved Hide resolved
docs/src/pages/migrations.md Outdated Show resolved Hide resolved
server/api/repo.go Outdated Show resolved Hide resolved
6543 and others added 3 commits December 2, 2024 00:52
@6543 @pat-s
Update cli/repo/repo_update.go
627539e 
Co-authored-by: Patrick Schratz <[email protected]>
@6543 @pat-s
Update docs/src/pages/migrations.md
46a771c 
Co-authored-by: Patrick Schratz <[email protected]>
@6543 @pat-s
Update server/api/repo.go
5f04748 
Co-authored-by: Patrick Schratz <[email protected]>
@pat-s
Copy link
Contributor

pat-s commented Dec 2, 2024

@anbraten Waiting for you (?)

anbraten
anbraten reviewed Dec 2, 2024
View reviewed changes
server/api/repo.go Outdated Show resolved Hide resolved
server/pipeline/gated.go Show resolved Hide resolved
server/store/datastore/migration/019_gated_to_require_approval.go Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.38776% with 15 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (9f0611d) to head (45d5d8d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ation/022_set-new-defaults-for-require_approval.go 68.96% 6 Missing and 3 partials ⚠️
server/api/repo.go 0.00% 3 Missing ⚠️
cli/repo/repo_update.go 0.00% 1 Missing ⚠️
server/pipeline/gated.go 90.90% 1 Missing ⚠️
...tastore/migration/019_gated_to_require_approval.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4456      +/-   ##
==========================================
+ Coverage   28.20%   28.25%   +0.05%     
==========================================
  Files         397      398       +1     
  Lines       28158    28167       +9     
==========================================
+ Hits         7941     7958      +17     
+ Misses      19512    19503       -9     
- Partials      705      706       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 requested a review from anbraten December 4, 2024 11:15
anbraten
anbraten reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration still seems to miss the deletion of the gated column. Will do a full review later today.

server/api/repo.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Dec 4, 2024

The migration still seems to miss the deletion of the gated column. Will do a full review later today.

this now is a 1:1 copy of what is in v2.8

@6543
Copy link
Member Author

6543 commented Dec 4, 2024

The migration still seems to miss the deletion of the gated column. Will do a full review later today.

this now is a 1:1 copy of what is in v2.8

nop look at server/store/datastore/migration/019_gated_to_require_approval.go there it is

@anbraten
Copy link
Member

anbraten commented Dec 4, 2024

nop look at server/store/datastore/migration/019_gated_to_require_approval.go there it is

Ahh perfect. It was now hidden as we had it in next already.

anbraten
anbraten approved these changes Dec 4, 2024
View reviewed changes
server/api/repo.go Outdated Show resolved Hide resolved
server/api/repo.go Outdated Show resolved Hide resolved
server/pipeline/gated.go Show resolved Hide resolved
server/store/datastore/migration/022_set-new-defaults-for-require_approval.go Outdated Show resolved Hide resolved
server/store/datastore/migration/022_set-new-defaults-for-require_approval.go Outdated Show resolved Hide resolved
@anbraten anbraten changed the title Set new default RequireApproval based on repo visibility Set new default approval mode based on repo visibility Dec 4, 2024
@anbraten anbraten enabled auto-merge (squash) December 4, 2024 15:16
@anbraten anbraten disabled auto-merge December 5, 2024 08:16
@anbraten anbraten merged commit 6e18a44 into woodpecker-ci:main Dec 5, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 5, 2024
Merged
1 task
@6543 6543 deleted the adjust-approval-migration-after-backport branch December 6, 2024 16:03
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
Open
1 task
pat-s added a commit that referenced this pull request Dec 18, 2024
@6543 @pat-s @anbraten
Set new default approval mode based on repo visibility (#4456)
6094a88 
Co-authored-by: Patrick Schratz <[email protected]>
Co-authored-by: Anbraten <[email protected]>
pat-s added a commit that referenced this pull request Dec 18, 2024
@6543 @pat-s @anbraten
Set new default approval mode based on repo visibility (#4456)
e66bf55 
Co-authored-by: Patrick Schratz <[email protected]>
Co-authored-by: Anbraten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat-s pat-s pat-s left review comments

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens enhancement improve existing features security
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @woodpecker-bot @pat-s @anbraten