Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netrc option description #4342

Merged
merged 11 commits into from
Nov 10, 2024
Merged

Update netrc option description #4342

merged 11 commits into from
Nov 10, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Nov 9, 2024

after discussion in #2585

feel free to add suggestions to update the wording.

@pat-s pat-s added the documentation docu & docs label Nov 9, 2024
@qwerty287
Copy link
Contributor

Not sure but I think the description in the ui is a bit too long. I'd like to check how that looks. This description was already the longest compared to the other ones. Maybe we can somehow shorten it without losing relevant information?

@pat-s
Copy link
Contributor Author

pat-s commented Nov 9, 2024

Didn't check it but maybe merge and adjust afterwards?

One option could be to add a link to the docs only which explains the option in more verbose wording.

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Nov 9, 2024

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-4342.surge.sh

docs/docs/20-usage/75-project-settings.md Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
@xoxys
Copy link
Member

xoxys commented Nov 9, 2024

I've adjusted the wording a bit and shortened the UI description.

@xoxys xoxys changed the title update netrc option description Update netrc option description Nov 9, 2024
@pat-s
Copy link
Contributor Author

pat-s commented Nov 10, 2024

@qwerty287 are you fine with the current changes?

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As some kind of a hotfix yes. Still I think it's too long. But as we're probably going to replace that with #2601 it's fine

@pat-s pat-s merged commit 9a61cdb into main Nov 10, 2024
7 checks passed
@pat-s pat-s deleted the docs/update-netrc-wording branch November 10, 2024 15:39
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 11, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation docu & docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants