Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renovate support for xgo #4276

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Fix renovate support for xgo #4276

merged 8 commits into from
Oct 30, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Oct 29, 2024

  • Use semver versions instead of .x (not detectable by renovate)
  • Include xgo version in Makefile
  • Clean Dockerfile.make: don't pin alpine versions, simplify node tags

@pat-s pat-s added the build CI pipeline related label Oct 29, 2024
.cspell.json Outdated Show resolved Hide resolved
Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xgo support would have been possible with the x version as well https://github.com/thegeeklab/renovate-presets/blob/main/golang.json#L40-L45

Makefile Outdated Show resolved Hide resolved
@pat-s
Copy link
Contributor Author

pat-s commented Oct 29, 2024

Ah, then we should change it to this 👍

@pat-s
Copy link
Contributor Author

pat-s commented Oct 29, 2024

Switched to @xoxys approach. Linked PR in preset: woodpecker-ci/renovate-config#21

.github/renovate.json Outdated Show resolved Hide resolved
@pat-s pat-s merged commit 3adcfb8 into main Oct 30, 2024
7 of 8 checks passed
@pat-s pat-s deleted the chore/renovate-xgo branch October 30, 2024 13:21
@woodpecker-bot woodpecker-bot mentioned this pull request Oct 30, 2024
1 task
@woodpecker-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants