-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all default privileged plugins #4053
Remove all default privileged plugins #4053
Conversation
re-add plugins to the list via config if needed
Tearing down https://woodpecker-ci-woodpecker-pr-4053.surge.sh |
I'm personally in fafour of #3918 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4053 +/- ##
==========================================
- Coverage 26.96% 26.94% -0.03%
==========================================
Files 394 394
Lines 27416 27418 +2
==========================================
- Hits 7393 7388 -5
- Misses 19323 19330 +7
Partials 700 700 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the overall issue: I don't see why we should keep only our plugins and I am in favor of removing all from the list.
Besides, similar to my comment in #3918, I think that we are lacking documentation about this change and it should be included in the PR that will be chosen in the end.
As this happened a few times in the past for user-visible changes, I would be really happy to see this being addressed this time.
Last, I think that WOODPECKER_ESCALATED
is a strange var name as it doesn't really indicate what "exactly" the setting is doing. Yes, it "escalates" something but that word per se has multiple meanings and is often rather used in a different context.
Why not something more specific like WOODPECKER_ALLOW_PRIVILEGED
or WOODPECKER_PLUGINS_PRIVILEGED
?
will be needed once woodpecker-ci/woodpecker#4053 released merged
created woodpecker-ci/infrastructure#91 |
https://ci.woodpecker-ci.org/repos/8981/pipeline/162/4 should have shown an lit error but it did not. this fix it a followup of #4053
…cker-ci#4083) https://ci.woodpecker-ci.org/repos/8981/pipeline/162/4 should have shown an lit error but it did not. this fix it a followup of woodpecker-ci#4053
…cker-ci#4083) https://ci.woodpecker-ci.org/repos/8981/pipeline/162/4 should have shown an lit error but it did not. this fix it a followup of woodpecker-ci#4053
re-add plugins to the list via config if needed