Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bitbucket Datacenter] Return empty list instead of null #4010

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jenrik
Copy link
Contributor

@jenrik jenrik commented Aug 6, 2024

This change make the Bitbucket Datacenter forge correctly return empty list instead of nil which indirectly fixes the "Run pipeline" button in the repository view.

Previously you where unable to manually run a pipeline because the frontend code expects the API to return a empty JSON array for the last page instead of the null value that where actually returned.

@qwerty287 qwerty287 added forge/bitbucket bitbucket forge related bug Something isn't working labels Aug 6, 2024
@qwerty287
Copy link
Contributor

@jenrik please update your branch

@jenrik jenrik force-pushed the fix/bitbucket-array-init branch from 42ec9d0 to 6ff8419 Compare August 6, 2024 16:13
@jenrik
Copy link
Contributor Author

jenrik commented Aug 6, 2024

@qwerty287 rebase completed

@lafriks lafriks enabled auto-merge (squash) August 6, 2024 16:21
@lafriks lafriks merged commit f20327e into woodpecker-ci:main Aug 6, 2024
7 checks passed
@jenrik jenrik deleted the fix/bitbucket-array-init branch August 6, 2024 16:33
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 6, 2024
1 task
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forge/bitbucket bitbucket forge related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants