Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman backend #305

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Add podman backend #305

wants to merge 21 commits into from

Conversation

mfulz
Copy link
Contributor

@mfulz mfulz commented Sep 14, 2021

closes #85

This is a first working podman backend, which can be used by calling the agent with --use-podman.

It is working on my environment fine for now, but would need broader testing.

This is a early version and cannot be called stable at all for now, but it makes sense to include it eary in my opinion.

@6543 6543 added the feature add new functionality label Sep 14, 2021
@6543 6543 added the wip label Sep 16, 2021
@6543

This comment has been minimized.

@6543

This comment has been minimized.

@mfulz

This comment has been minimized.

@6543

This comment has been minimized.

@mfulz
Copy link
Contributor Author

mfulz commented Sep 21, 2021

It will take me some time but I'll do migrate them one by one ... - you can just merge master into from time to time to check if it will start working untill it do ;)

Great I'lll work further on the implementation in between as well

@anbraten anbraten marked this pull request as draft September 24, 2021 10:46
@6543
Copy link
Member

6543 commented Sep 26, 2021

@mfulz now it is building - I think you can move forward :)

agent/runner.go Outdated Show resolved Hide resolved
@6543 6543 added this to the 1.0.0 milestone Feb 6, 2022
@anbraten anbraten removed the wip label Sep 20, 2022
@anbraten anbraten changed the title Podman backend Add podman backend Sep 20, 2022
@anbraten anbraten removed this from the 1.0.0 milestone May 30, 2023
@pat-s
Copy link
Contributor

pat-s commented Jul 14, 2023

Is this in essence compatible with next or would it need a complete rewrite? (assuming it was based off from 0.15.x initially).

@6543
Copy link
Member

6543 commented Jul 15, 2023

It targets the main branch ... so its next what ever version next is going to be when it's finished :)

The interface for backends did not changed that mouch ... at all anyway

@pat-s
Copy link
Contributor

pat-s commented Jul 15, 2023

@mfulz Are you still using your interface or WP at all? Curious how close this is to be "production ready", also given how long this PR is already open :)

@mfulz
Copy link
Contributor Author

mfulz commented Jul 16, 2023

@mfulz Are you still using your interface or WP at all? Curious how close this is to be "production ready", also given how long this PR is already open :)

Sorry for the silence atm this is stalled for me, as I'm loaded with too much other things, that cannot be postponed :(
I was just checking wp out and drafted the podman stuff and definitely go to proceed with this.

But when this will happen is impossible to tell atm. could be end of this year or next year - sorry for that

EDIT: Sorry the mark ready was a missclick

@mfulz mfulz marked this pull request as ready for review July 16, 2023 18:22
@mfulz
Copy link
Contributor Author

mfulz commented Jul 16, 2023

At least I can fix the errors for the checks if that would help.
But I cant access the details on what is failing for the test, can someone help me out here?

@6543
Copy link
Member

6543 commented Jul 16, 2023

Well then just let it open as is ... open pulls per se dont hurt.

Others can base new pulls on it or this gets ready ...

@qwerty287 qwerty287 added this to the 3.x.x milestone Nov 4, 2023
@anbraten anbraten marked this pull request as draft December 24, 2023 08:38
@qwerty287 qwerty287 added the backend new backend label Dec 31, 2023
@anbraten anbraten removed this from the 3.x.x milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend new backend feature add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "native" podman as backend
5 participants