Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go module path for major version 2 #2905

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

runephilosof-karnovgroup
Copy link
Contributor

@runephilosof-karnovgroup runephilosof-karnovgroup commented Dec 4, 2023

https://go.dev/doc/modules/release-workflow#breaking

Fixes #2913 fixes #2654

runephilosof@fedora:~/code/platform-woodpecker/woodpecker-repo-configurator (master)$ go get go.woodpecker-ci.org/[email protected]
go: go.woodpecker-ci.org/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("go.woodpecker-ci.org/woodpecker/v2")

@runephilosof-karnovgroup
Copy link
Contributor Author

I am not an experienced Go developer, but it seems like this is the way it is supposed to be done

@runephilosof-karnovgroup runephilosof-karnovgroup marked this pull request as ready for review December 6, 2023 12:26
@runephilosof-karnovgroup
Copy link
Contributor Author

I should mention. I haven't yet figured out how to test that this change is correct

This is the error that lead me to create this PR

user@fedora:~/code/platform-woodpecker/woodpecker-repo-configurator (master)$ go get go.woodpecker-ci.org/[email protected]
go: go.woodpecker-ci.org/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("go.woodpecker-ci.org/woodpecker/v2")

@qwerty287 qwerty287 added this to the 2.1.0 milestone Dec 7, 2023
@qwerty287 qwerty287 added bug Something isn't working refactor delete or replace old code labels Dec 7, 2023
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Dec 7, 2023

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-2905.surge.sh

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (428fe65) 33.93% compared to head (8de4fb6) 33.89%.
Report is 6 commits behind head on main.

❗ Current head 8de4fb6 differs from pull request most recent head a04f53e. Consider uploading reports for the commit a04f53e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2905      +/-   ##
==========================================
- Coverage   33.93%   33.89%   -0.04%     
==========================================
  Files         219      219              
  Lines       13829    13829              
==========================================
- Hits         4693     4688       -5     
- Misses       8778     8783       +5     
  Partials      358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

webhook-data Outdated Show resolved Hide resolved
woodpecker-server-tags Outdated Show resolved Hide resolved
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't know however if you did everything correctly and if this automatically works with our go vanity URL.

@runephilosof-karnovgroup
Copy link
Contributor Author

I just did a search and replace and I have not looked through every change manually.
So hopefully some experienced go developer will contribute to the PR 🤞

@lafriks
Copy link
Contributor

lafriks commented Dec 7, 2023

please resolve conflicts

@anbraten anbraten enabled auto-merge (squash) December 8, 2023 06:11
@anbraten anbraten merged commit adb2c82 into woodpecker-ci:main Dec 8, 2023
6 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 8, 2023
1 task
@runephilosof-karnovgroup runephilosof-karnovgroup deleted the go-version-v2 branch December 11, 2023 07:52
@runephilosof-karnovgroup
Copy link
Contributor Author

This PR should not have been merged yet.
The changes had not been tested.

user@fedora:~/code/platform-woodpecker/woodpecker-repo-configurator (upgrade-go-library-2.x)$ go get -u go.woodpecker-ci.org/woodpecker@main
go: go.woodpecker-ci.org/woodpecker@main: go.woodpecker-ci.org/[email protected]: invalid version: go.mod has post-v0 module path "go.woodpecker-ci.org/woodpecker/v2" at revision fb7619a5c842

6543 pushed a commit that referenced this pull request Dec 26, 2023
## [2.1.0](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.1.0)
- 2023-12-26

### ✨ Features

- Add pull request closed event
[[#2684](#2684)]
- Add depends_on support for steps
[[#2771](#2771)]
- gitlab: support nested repos
[[#2981](#2981)]
- Support go plugins for forges and agent backends
[[#2751](#2751)]

### 📈 Enhancement

- Show default branch on top
[[#3019](#3019)]
- Support more addon types
[[#2984](#2984)]
- Hide PR tab if PRs are disabled
[[#3004](#3004)]
- Switch to ULID
[[#2986](#2986)]
- Ignore pipelines without config
[[#2949](#2949)]
- Link labels to input and select
[[#2974](#2974)]
- Register Agent with hostname
[[#2936](#2936)]
- Update slogan & logo
[[#2962](#2962)]
- Improve error handling when activating a repository
[[#2965](#2965)]
- Add check for storage where repo/org name is empty
[[#2968](#2968)]
- Update pipeline icons
[[#2783](#2783)]
- Kubernetes refactor
[[#2794](#2794)]
- Export changed files via builtin environment variables
[[#2935](#2935)]
- Show secrets from org and global level
[[#2873](#2873)]
- Only update pipelineStatus in one place
[[#2952](#2952)]
- Rename `engine` to `backend`
[[#2950](#2950)]
- Add linting for `log.Fatal()`
[[#2946](#2946)]
- Remove separate root path config
[[#2943](#2943)]
- init CI_COMMIT_TAG if commit ref is a tag
[[#2934](#2934)]
- Update go module path for major version 2
[[#2905](#2905)]
- Unify date/time dependencies
[[#2891](#2891)]
- Add linting for `any`
[[#2893](#2893)]
- Fix vite deprecations
[[#2885](#2885)]
- Migrate to Xormigrate
[[#2711](#2711)]
- Simple security context options (Kubernetes)
[[#2550](#2550)]
- Changes PullRequest Index to ForgeRemoteID type
[[#2823](#2823)]

### 🐛 Bug Fixes

- Hide queue visualization if nothing to show
[[#3003](#3003)]
- fix and lint swagger file
[[#3007](#3007)]
- Fix IPv6 host aliases for kubernetes
[[#2992](#2992)]
- Fix cli lint throwing error on warnings
[[#2995](#2995)]
- Fix static file caching
[[#2975](#2975)]
- Gitea driver: ignore GetOrg error if we get a valid user.
[[#2967](#2967)]
- feat(k8s): Add a port name to service definition
[[#2933](#2933)]
- Fix error container overflow
[[#2957](#2957)]
- ignore some errors on repairAllRepos
[[#2792](#2792)]
- Allow to restart pipelines that has warnings
[[#2939](#2939)]
- Fix skipped pipelines model
[[#2923](#2923)]
- fix: Add `backend_options` to service linter entry
[[#2930](#2930)]
- Fix flags added multiple times
[[#2914](#2914)]
- Fix schema validation with array syntax for clone and services
[[#2920](#2920)]
- Fix prometheus docs
[[#2919](#2919)]
- Fix podman agent container in v2
[[#2897](#2897)]
- Fix bitbucket org fetching
[[#2874](#2874)]
- Only deploy docs on `main`
[[#2892](#2892)]
- Fix pipeline-related environment
[[#2876](#2876)]
- Fix version check partially
[[#2871](#2871)]
- Fix unregistering agents when using agent tokens
[[#2870](#2870)]

### 📚 Documentation

- [Awesome Woodpecker] added yet another autoscaler
[[#3011](#3011)]
- Add cookbook blog and improve docs
[[#3002](#3002)]
- Replace multi-pipelines with workflows on docs frontpage
[[#2990](#2990)]
- Update README badges
[[#2956](#2956)]
- Update 20-kubernetes.md
[[#2927](#2927)]
- Add release documentation to CONTRIBUTING
[[#2917](#2917)]
- Add nix-attic plugin to the index
[[#2889](#2889)]
- Add usage with Tunnelmole to docs
[[#2881](#2881)]
- Improve code blocks in docs
[[#2879](#2879)]
- Add a blog post
[[#2877](#2877)]
- Add documentation on Kubernetes securityContext
[[#2822](#2822)]
- Add default page to categories
[[#2869](#2869)]
- Use same format for Github docs as used for the other forges
[[#2866](#2866)]

### Misc

- chore(deps): update dependency isomorphic-dompurify to v2
[[#3001](#3001)]
- fix(deps): update dependency @intlify/unplugin-vue-i18n to v2
[[#2998](#2998)]
- Fix go in gitpod
[[#2973](#2973)]
- fix(deps): update module google.golang.org/grpc to v1.60.1
[[#2969](#2969)]
- chore(deps): update docker.io/alpine docker tag to v3.19
[[#2970](#2970)]
- Fix broken gated repos
[[#2959](#2959)]
- fix(deps): update golang (packages)
[[#2958](#2958)]
- Update docker.io/techknowlogick/xgo Docker tag to go-1.21.5
[[#2926](#2926)]
- Update docker.io/golang Docker tag to v1.21.5
[[#2925](#2925)]
- Lock file maintenance
[[#2910](#2910)]
- Update web npm deps non-major
[[#2909](#2909)]
- Update docs npm deps non-major
[[#2908](#2908)]
- Update golang (packages)
[[#2904](#2904)]
- Update module github.com/google/go-github/v56 to v57
[[#2899](#2899)]
- Update dependency marked to v11
[[#2898](#2898)]
- Update dependency vite-svg-loader to v5
[[#2837](#2837)]
- Update golang (packages)
[[#2894](#2894)]
- Update web npm deps non-major
[[#2895](#2895)]
- Update web npm deps non-major
[[#2884](#2884)]
- Update docker.io/woodpeckerci/plugin-docker-buildx Docker tag to
v2.2.1 [[#2883](#2883)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go module path for major version 2 Using main branch commit in go.mod is a downgrade (0.15.1)
5 participants