Remove repo pass netrc option from repos #2214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-2214.surge.sh |
|
before we remove that option, we nee to make sure why it was added in the first place and if this can be solved in an other way now :) |
6543
added
the
breaking
|
@6543 It was added as fallback to allow custom clone images which are not listed as trusted images. |
|
closing as of #2601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not trusted clone plugins should never get our credentials as an attacker could simply replace the clone step by a malicious one and therefore gather netrc credentials.