Move from "master" to "main" as fallback for default repo branches #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d make it configurable
6543
added
refactor
Merged
This comment was marked as off-topic.
This comment was marked as off-topic.
qwerty287
reviewed
Jul 29, 2023
| @@ -169,6 +169,12 @@ var flags = []cli.Flag{ | |||
| Usage: "The default time in minutes for a repo in minutes before a pipeline gets killed", | |||
| Value: 60, | |||
| }, | |||
| &cli.StringFlag{ | |||
| EnvVars: []string{"WOODPECKER_DEFAULT_REPO_BRANCH"}, | |||
|
@6543 I don't think we need to have that fallback at all. I checked gitea, github and gitlab and they all have values for the default-branch. For bitbucket I will check how we can get that value as well. |
|
yes I would prefer to just relay on the forge |
|
Just did not do research if forges do have a change to report it empty |
|
-> #2065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and make it configurable