Use full qualifyer for images and user quay.io if possible #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
reviewed
Mar 20, 2023
6543
force-pushed
the
add_quay.io_as_backup_and_full_qualifyer
branch
from
28e1f42 to
091d1d4
Compare
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1659.surge.sh |
anbraten
reviewed
Mar 21, 2023
| @@ -103,7 +104,7 @@ pipeline: | |||
|
|
|||
| codecov: | |||
| pull: true | |||
There was a problem hiding this comment.
Should probably be removed as well.
|
Using the FQ for quay for rate limiting or what's the motivation? |
|
yes it was created while Docker Inc. try to remove OpenSource orgs I still think we should still provide an other option as docker-hub. but it's not as urgent anymore |
|
we first need -> #1995 |
Nothing to say against this but I think it's not necessary to add |
|
Conflicts resolved in #2692 |
6543
added a commit
that referenced
this pull request
Nov 1, 2023
Supersedes #1659 --------- Co-authored-by: 6543 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
& bump alpine to alpine:3.17