-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: global secret #148
feat: global secret #148
Conversation
CrabHo
commented
Nov 23, 2020
- List
- Add
- Info
- Update
- Remove
High quality PR. Need a couple of days to crosscheck it with https://woodpecker.laszlo.cloud/environment-variables/#global-environment-variables What do you think about the feature overlap of the two? |
env is for organization to setup non credentials data. e.g organization root domain, jira link or other data. secret is for admin to set token like docker username and password. in my opinion there are different purpose. |
Thank you for the contributions. I'm now processing the backlog of PRs and my goal is to merge this in the coming days. |
@CrabHo I see that this is building on top of the original Drone global secrets feature. The problem here is that parts of that was not licensed with Apache2. I see that you pulled in the Apache code, but haven't got to the end in figuring out if all files are Apache or not. It would help if you write down the approach you followed with the non Apache 2 code. |
Hello folks, What's up with this feature? :) Moreover, are global secret shared with all repositories or only scoped with an organization? |
I think this is now implemented in #1027 (which supports both global and organization levels), so we can close this? |
@qwerty287 I think yes, my PR fully replaces this one, except for drone cli part. |
I can implement CLI later on in other PR as I did not want to make PR too big :) |