Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global secret #148

Closed
wants to merge 10 commits into from
Closed

Conversation

CrabHo
Copy link
Contributor

@CrabHo CrabHo commented Nov 23, 2020

  • List
drone globalsecret ls
  • Add
drone globalsecret add --name foo --value bar
  • Info
drone globalsecret info --name foo
  • Update
drone globalsecret update --name foo --event pull_request
  • Remove
drone globalsecret rm --name foo

@CrabHo CrabHo closed this Nov 23, 2020
@CrabHo CrabHo reopened this Nov 23, 2020
@laszlocph
Copy link
Member

High quality PR.

Need a couple of days to crosscheck it with https://woodpecker.laszlo.cloud/environment-variables/#global-environment-variables
How the two features can co-exist.

What do you think about the feature overlap of the two?

@CrabHo
Copy link
Contributor Author

CrabHo commented Nov 26, 2020

env is for organization to setup non credentials data. e.g organization root domain, jira link or other data.

secret is for admin to set token like docker username and password.

in my opinion there are different purpose.

@laszlocph
Copy link
Member

Thank you for the contributions. I'm now processing the backlog of PRs and my goal is to merge this in the coming days.

@laszlocph
Copy link
Member

@CrabHo I see that this is building on top of the original Drone global secrets feature.

The problem here is that parts of that was not licensed with Apache2. I see that you pulled in the Apache code, but haven't got to the end in figuring out if all files are Apache or not.

It would help if you write down the approach you followed with the non Apache 2 code.

@6543 6543 added the feature add new functionality label Jun 18, 2021
@catdevnull catdevnull mentioned this pull request Sep 30, 2021
@6543 6543 added this to the 0.16.0 milestone Dec 13, 2021
@Tchoupinax
Copy link
Contributor

Hello folks,

What's up with this feature? :)

Moreover, are global secret shared with all repositories or only scoped with an organization?

@qwerty287
Copy link
Contributor

I think this is now implemented in #1027 (which supports both global and organization levels), so we can close this?

@lafriks
Copy link
Contributor

lafriks commented Aug 2, 2022

@qwerty287 I think yes, my PR fully replaces this one, except for drone cli part.

@lafriks
Copy link
Contributor

lafriks commented Aug 2, 2022

I can implement CLI later on in other PR as I did not want to make PR too big :)

@qwerty287 qwerty287 closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants