Missing root path in GitLab webhook

[rodarima]

Component

server

Describe the bug

When enabling a new GitLab repository, the webhook is set in GitLab with the API address https://example.com/api/hook. However, the server has the WOODPECKER_ROOT_PATH=/ci, and it should be https://example.com/ci/api/hook in my case.

Changing it manually in the GitLab configuration fails because the GitLab webhook token gets erased and I don't know where to get it from, so I cannot use the webhook.

I suspect the problem is here: https://github.com/woodpecker-ci/woodpecker/blob/931af16d14e94fbf6fbb94a167251fc2d6bedded/server/forge/gitlab/gitlab.go#L450C57-L450C57

System Info

I'm using woodpecker-server 1.0.2 in NixOS:

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"1.0.2"}

Additional context

No response

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[rodarima]

Yep, this patch fixes it for me:

diff --git a/server/forge/gitlab/gitlab.go b/server/forge/gitlab/gitlab.go
index 8f2593c7..fa0fc4ea 100644
--- a/server/forge/gitlab/gitlab.go
+++ b/server/forge/gitlab/gitlab.go
@@ -447,7 +447,7 @@ func (g *GitLab) getTokenAndWebURL(link string) (token, webURL string, err error
                return "", "", err
        }
        token = uri.Query().Get("access_token")
-       webURL = fmt.Sprintf("%s://%s/api/hook", uri.Scheme, uri.Host)
+       webURL = fmt.Sprintf("%s://%s/ci/api/hook", uri.Scheme, uri.Host)
        return token, webURL, nil
 }

[rodarima]

Thanks for the fix @qwerty287. I also observed that in the GitLab pipelines (https://gitlab.example.com/user/repo/-/pipelines/123), the link to the Woodpecker pipeline is also missing the root path:

Links to

https://example.com/repos/1/pipeline/39/1

Rather than

https://example.com/ci/repos/1/pipeline/39/1

[rodarima]

Seem to be coming from here:

woodpecker/server/forge/common/status.go

Lines 75 to 81 in 4e0b0bd

	func GetPipelineStatusLink(repo *model.Repo, pipeline *model.Pipeline, workflow *model.Workflow) string {
	if workflow == nil {
	return fmt.Sprintf("%s/repos/%d/pipeline/%d", server.Config.Server.Host, repo.ID, pipeline.Number)
	}
	return fmt.Sprintf("%s/repos/%d/pipeline/%d/%d", server.Config.Server.Host, repo.ID, pipeline.Number, workflow.PID)
	}

[qwerty287]

Yes, but your WOODPECKER_HOST env var should also contain the path (the documentation has been improved for next already)