Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable HTTPS_PROXY environment variable always being passed through. #2208

Closed
4 tasks done
wkpatrick opened this issue Aug 13, 2023 · 0 comments · Fixed by #2242
Closed
4 tasks done

Ability to disable HTTPS_PROXY environment variable always being passed through. #2208

wkpatrick opened this issue Aug 13, 2023 · 0 comments · Fixed by #2242
Labels
enhancement improve existing features
Milestone

Comments

@wkpatrick
Copy link

Clear and concise description of the problem

One of the libraries in my project attempts to use a proxy if HTTPS_PROXY is set as a variable, even if it is just blank.

Suggested solution

Possible solutions discussed in the matrix room by 6543:

"Well we just either need to add a option to
https://github.com/woodpecker-ci/woodpecker/blob/main/pipeline/frontend/yaml/compiler/option.go#L219
and expose it as flag or add a check to
https://github.com/woodpecker-ci/woodpecker/blob/main/pipeline/frontend/yaml/compiler/option.go#L228
If all 3 are "" and if so ignore it
I'm for second one ..."

Alternative

No response

Additional context

No response

Validations

  • Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@wkpatrick wkpatrick added the feature add new functionality label Aug 13, 2023
@6543 6543 added this to the 1.1.0 milestone Aug 18, 2023
@6543 6543 added enhancement improve existing features and removed feature add new functionality labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants