CYS: improve font installation with the async job #45411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: refactor
github-actions
bot
added
the
plugin: woocommerce
|
Hi @albarin, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 04b1dbd
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
…ve/font_installation_async
…rce/woocommerce into improve/font_installation_async
github-actions
bot
added
the
needs: analysis
Stojdza
added
needs: external testing
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* CYS: improve font installation with the async job * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Following the recent discussion on the Font Library and wp_get_font_dir outlined in this post, an observation was made regarding a potential infinite loop in the code responsible for uploading fonts within the Gutenberg editor.
This PR addresses the issue by implementing changes to the font upload code. The adjustments aim to prevent the occurrence of an infinite loop, as detailed in the context of the reported problem. For more details, please refer to the related Gutenberg GitHub repository: WordPress/gutenberg/pull/58839.
This PR applies the patches on our codebase.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
These testing instructions require a connection with the database
/wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag.wp_font_family,wp_font_faceandwp_global_styles./wp-admin/admin.php?page=wc-settings&tab=advanced§ion=woocommerce_comand enable the tracking./wp-admin/admin.php?page=wc-status&tab=action-schedulerand ensure thatwoocommerce_install_assembler_fontsis in pending.woocommerce_install_assembler_fontsjob doesn't fail.wp-admin/admin.php?page=wc-admin&path=/customize-store./font-faces/endpoint. (it is expected that GET requests are done).Changelog entry
Significance
Type
Message
Comment
CYS: improve font installation with the async job.