-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS] Temporarily remove the survey button #41781
Conversation
Hi @chihsuan, @gigitux, @moon0326, @adrianduffell, @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 396f1e5
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d172505
to
c38c195
Compare
b368f76
to
c7672ea
Compare
f57bf75
to
a4b459f
Compare
a09212d
to
6806f61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and confirmed the survey button is not shown when AI is offline. 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Confirmed the survey button is not displayed whenever AI is unavailable.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #41637
Depends on #41656
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Set up woocommerce-gutenberg-products-block from woocommerce/woocommerce-blocks#11890
customize-store
feature flag inTools -> WCA Test Helper -> Features
WooCommerce -> Home
and click onCustomize your store
task.status.indicator
tomajor
.Done
in the assembler.Share feedback
button in the last step page.Share feedback
button appears.Changelog entry
Significance
Type
Message
Hide the "Share feedback" button from the CYS preview step when AI is not available.
Comment