Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS] Temporarily remove the survey button #41781

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Nov 29, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #41637
Depends on #41656

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Set up woocommerce-gutenberg-products-block from woocommerce/woocommerce-blocks#11890

  1. Create a new site either via local environment or JN. Make sure to install WooCommerce Beta Tester as well.
  2. Enable customize-store feature flag in Tools -> WCA Test Helper -> Features
  3. Go to WooCommerce -> Home and click on Customize your store task.
  4. Open your browser's inspector and use Chrome's content override feature to change the content of https://status.openai.com/api/v2/status.json call. Change status.indicator to major.
  5. Refresh the page, go through the process and click Done in the assembler.
  6. You should not see Share feedback button in the last step page.
Screenshot 2023-11-29 at 15 12 56
  1. Repeat the process removing the overridden response and make sure the Share feedback button appears.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Hide the "Share feedback" button from the CYS preview step when AI is not available.

Comment

@albarin albarin marked this pull request as ready for review November 29, 2023 14:19
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Hi @chihsuan, @gigitux, @moon0326, @adrianduffell, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Test Results Summary

Commit SHA: 396f1e5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests256006026214m 19s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 5, 2023
@albarin albarin force-pushed the 41637/remove-survey-button branch from d172505 to c38c195 Compare December 5, 2023 14:09
@albarin albarin added focus: ai team: Kirigami & Origami WC Store Editing (FSE) labels Dec 5, 2023
@moon0326 moon0326 force-pushed the update/41623-cys-ai-offline-flow branch from b368f76 to c7672ea Compare December 5, 2023 20:30
@chihsuan chihsuan force-pushed the update/41623-cys-ai-offline-flow branch from f57bf75 to a4b459f Compare December 6, 2023 09:43
Base automatically changed from update/41623-cys-ai-offline-flow to trunk December 6, 2023 12:49
@gigitux gigitux force-pushed the 41637/remove-survey-button branch from a09212d to 6806f61 Compare December 6, 2023 13:43
@github-actions github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 6, 2023
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and confirmed the survey button is not shown when AI is offline. 🚢

Copy link
Contributor

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Confirmed the survey button is not displayed whenever AI is unavailable.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 7, 2023
@nefeline nefeline merged commit d9ca827 into trunk Dec 7, 2023
15 checks passed
@nefeline nefeline deleted the 41637/remove-survey-button branch December 7, 2023 12:16
@github-actions github-actions bot added this to the 8.5.0 milestone Dec 7, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Dec 7, 2023
@nigeljamesstevenson nigeljamesstevenson added needs: internal testing Indicates if the PR requires further testing conducted by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Dec 8, 2023
@nigeljamesstevenson nigeljamesstevenson added the status: analysis complete Indicates if a PR has been analysed by Solaris label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: ai needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami WC Store Editing (FSE)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS] Temporarily remove the survey button
5 participants