WC 4.4.1 Compatibility Bump #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chickenn00dle This LGTM. However, the Travis CI build fails. I think we'll need to fix the subscriptions repo URL here: https://github.com/woocommerce/woocommerce-subscriptions-importer-exporter/blob/master/tests/bin/travis.sh. I'll do it and see if that helps. |
|
@codestor4 @chickenn00dle can you get this merged? |
This replaces the use of WC_Subscription::update_manual which was deprecated in WC Subscriptions in version 2.2.0 in favor of WC_Subscriptions::set_requires_manual_renewal.
This replaces direct access of subscription ID with call to get_id() as direct property access is no longer supported as of WC 3.0.
This updates the WC compat headers to reflect this has been tested up to 4.4.1.
wigglemuff
force-pushed
the
wc_4.4_compatibility
branch
from
8f1b941 to
62e3607
Compare
|
I did a rebase of this with master with the hope that these changes would help fix the Travis build issue. Travis build still fails but for other reasons (PHPCS issues). We can fix PHPCS issues in a separate PR. I'll go ahead and merge this now! |
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the
WC tested up toheader to 4.4.1.This also does the following:
WC_Subscription::update_manualwithWC_Subscription::set_requires_manual_renewal.get_id()I tested this with the latest versions of WC, WC Subs, and WC Memberships.
Closes #223