Execute server-side WC validation when clicking button #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise old messages may get stuck
Dinamiko
approved these changes
Oct 27, 2022
| onError: () => { | ||
| this.errorHandler.genericError(); | ||
| onError: (err) => { | ||
| console.error(err); |
There was a problem hiding this comment.
Is this console error on purpose here?
There was a problem hiding this comment.
Yes, we don't show it on the page, so should show it at least in console if it comes from other sources.
modules/ppcp-button/resources/js/modules/ContextBootstrap/CartBootstap.js
Outdated
Show resolved
Hide resolved
modules/ppcp-button/resources/js/modules/ContextBootstrap/CheckoutBootstap.js
Show resolved
Hide resolved
modules/ppcp-button/resources/js/modules/ContextBootstrap/MiniCartBootstap.js
Show resolved
Hide resolved
modules/ppcp-button/resources/js/modules/ContextBootstrap/SingleProductBootstap.js
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added execution of WC
validate_checkoutduring order creation.This should be better than the basic JS validation #513, but it is still done in a bit non-standard/hacky way, may break depending on other plugins using the hooks, WC version (the method is not the public API, though hopefully
protectedis close enough to that and unlikely to have breaking changes) etc. There is a filter for disabling it. Also we catch/log the (non-validation) errors during the validation execution, if this happens it will be skipped and continue like before #513. The JS validation also remains for now, but disabled by default.Also fixed
errorHandlers in JS, there were multiple instances of these objects creating their own error lists on the page, which was resulting in outdated messages still being present in some cases.And it seems like after bb86f1b the order creation errors were replaced by the generic message (though probably not just this commit because after simply reverting it the messages were still broken), so fixed this too.