Ensure 3ds contingency uses SCA_ALWAYS instead of 3D_SECURE (521)
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the 3D SECURE contingency to SCA_ALWAYS
Closed
AlexP11223
reviewed
Feb 3, 2022
| $this->settings->set( '3d_secure_contingency', 'SCA_ALWAYS' ); | ||
| $this->settings->persist(); | ||
|
|
||
| $redirect_url = admin_url( 'admin.php?page=wc-settings&tab=checkout§ion=ppcp-gateway' ); |
There was a problem hiding this comment.
Maybe should redirect to the cards tab? admin.php?page=wc-settings&tab=checkout§ion=ppcp-gateway&ppcp-tab=ppcp-credit-card-gateway
Or maybe redirect not needed here at all.
Also as I understand it is executed only if the merchant saves settings. Maybe better to do that simply on some kind of plugin init/upgrade, such as woocommerce_paypal_payments_gateway_migrate.
There was a problem hiding this comment.
yup, much better on plugin upgrade, thanks!
AlexP11223
requested changes
Feb 3, 2022
| add_action( | ||
| 'woocommerce_paypal_payments_gateway_migrate', | ||
| static function () use ( $c ) { | ||
| $settings = $c->get( 'wcgateway.settings' ); |
There was a problem hiding this comment.
I would add a type hint here to help psalm and IDE.
assert( $settings instanceof Settings );
AlexP11223
approved these changes
Feb 3, 2022
Dinamiko
changed the title
SCA_ALWAYS instead of 3D_SECURESCA_ALWAYS instead of 3D_SECURE (521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add improvements to #463.
This PR ensures that
SCA_ALWAYSis used instead of3D_SECUREstored in the database: https://github.com/woocommerce/woocommerce-paypal-payments/pull/463/files#diff-01a2758cc519d8adb065af0350c9459edb64a45576b4a2e527e8d2059c7889cbL1922-R1922Testing package
PCP-521-woocommerce-paypal-payments.zip
Acceptance criteria
SCA_WHEN_REQUIRED.3D_SECUREoption saved,SCA_ALWAYSoption value should be automatically updated**Note that only the value is updated, the option label is still the same (Always trigger 3D Secure).
Also note that in order to trigger the update the plugin needs to be upgraded, the provided package contains a higher plugin version which needs to be uploaded and installed from Plugins admin screen (replace existing with the new one).