Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate spinner when credit card button is clicked #45

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

websupporter
Copy link
Member

Fixes #39

@chickenn00dle chickenn00dle self-assigned this Sep 29, 2020
@chickenn00dle
Copy link
Contributor

Thanks for getting to this so quickly @websupporter!

This mostly looks good. I left one comment above which isn't absolutely necessary. Let me know what you think.

@websupporter
Copy link
Member Author

Hi @chickenn00dle, form.woocommerce-checkout seems the right target. changed in 7caa0d3

@chickenn00dle
Copy link
Contributor

Nice! This is much better.

I ran into one other issue while confirming just now. If I use an unsupported card, the spinner will be stuck blocking even after the payment has failed: https://d.pr/i/KGuvTf

This may end up needing to be a separate PR to address unhandled errors, so let me know if you'd like to tackle this here.

@websupporter
Copy link
Member Author

Hi @chickenn00dle,
this issue is solved in the latest commit of #8. There we check if the card is valid before even starting the spinner. I merged the branches together to see if it works, and it was okay:

https://www.youtube.com/watch?v=LrdKPLBVlEs

@chickenn00dle
Copy link
Contributor

chickenn00dle commented Sep 30, 2020

Nice! Thanks for connecting the dots here. I left some feedback in #8. I believe you're correct that the issue is solved there, but will wait for that to be merged before moving forward here.

@chickenn00dle
Copy link
Contributor

As mentioned, #8 has resolved the issue I pointed out above. All that is left is to resolve conflicts and this will be good to go.

@chickenn00dle
Copy link
Contributor

Merging!

@chickenn00dle chickenn00dle merged commit 60d2766 into master Oct 2, 2020
@chickenn00dle chickenn00dle deleted the issue-39-missing-spinning-wheel branch October 2, 2020 01:26
@wazhoare wazhoare mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Card Processing] Lag between place order button click and UI loading indicator
2 participants