-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate spinner when credit card button is clicked #45
Conversation
Thanks for getting to this so quickly @websupporter! This mostly looks good. I left one comment above which isn't absolutely necessary. Let me know what you think. |
Hi @chickenn00dle, |
Nice! This is much better. I ran into one other issue while confirming just now. If I use an unsupported card, the spinner will be stuck blocking even after the payment has failed: https://d.pr/i/KGuvTf This may end up needing to be a separate PR to address unhandled errors, so let me know if you'd like to tackle this here. |
Hi @chickenn00dle, |
Nice! Thanks for connecting the dots here. I left some feedback in #8. I believe you're correct that the issue is solved there, but will wait for that to be merged before moving forward here. |
As mentioned, #8 has resolved the issue I pointed out above. All that is left is to resolve conflicts and this will be good to go. |
Merging! |
Fixes #39